A better way to handle rotation with controller input?

AkimBow

I've used this code for a while now, it gets controller axis input and rotates a node. It worked fine but I was wondering if there is a way to improve it or even a better solution all together.

var direction = Input.get_vector("look_left", "look_right", "look_up", "look_down")
if direction .x >= 0.01 or direction .x <= -0.01 and direction .y >= 0.01 or direction .y <= -0.01:
		node.global_rotation = atan2(direction .y, direction .x)`

cybereality

This line is correct:

var direction = Input.get_vector("look_left", "look_right", "look_up", "look_down")

This line could be simplified to:

if direction.length() > 0.01:
	node.global_rotation = atan2(direction.y, direction.x)

Kojack

One thing to be careful of there is the precedence (order) of the logical operators. "and" happens before "or" if you don't group them with brackets. You can think of "and" being like multiply and "or" being like addition.
So effectively what the if line was doing is:

if direction .x >= 0.01 or (direction .x <= -0.01 and direction .y >= 0.01) or direction .y <= -0.01:

That would mean pushing the thumbstick purely right would work, pushing it purely up would work, but pushing it left or down only works if there's a bit of both.

Cyber's way is easier, but if you wanted the explicit logic then it would work correctly as:

if direction .x >= 0.01 or direction .x <= -0.01 or direction .y >= 0.01 or direction .y <= -0.01:

cybereality

Good catch.