Execution order: Page 2 - Godot Community Forums

Execution order

rui_mac

I have a script attached to the Universe node, that sends a signal to the planet_texture node and waits for a signal from the planet_texture script,, telling that it finished working. Then, it sends a signal to the planet_mesh node.
I have scripts in the planet_texture node to create a bitmap and in the planet_mesh node to create the geometry.

As of now, I'm not creating any instances. So, I only have the nodes that I need and I will not be creating more, so I don't need to delete anything.

Wolfe

Signals are confusing. Instead of defining your own and connecting them for this case, the built-in "completed" signal should work.

# Universe
func _ready():
    yield($"planet_stuff/planet_texture".calculate_all(), "completed")
    $"planet_stuff/planet_mesh".calculate_mesh()

You may have to add yield(get_tree(), "idle_frame") to the end of calculate_all() to get it to work. I'm not certain if that's needed to correctly receive the "completed" signal, but here's a functioning mockup:

extends Node

func _ready():
	yield(calculate_all(), "completed")
	calculate_mesh()


func calculate_all():
	print("Heightmap calculated.")
	yield(get_tree(), "idle_frame")


func calculate_mesh():
	print("Mesh created.")

rui_mac

I'm still getting the "Attempt to call 'get_texture' in base 'null instance' on a null instance" error.
If I'm accessing the texture of a viewport node that is a sibling of the planet_mesh node, where the script resides, the path should be "../planet_texture", since the ".." goes up one level, pointing to the parent node of both the planet_texture node and the planet_mesh node (where the script resides), and then points to the child planet_texture, right?
I mean, with this hierarchy...

planet_stuff
--planet_texture
--planet_mesh

if I have a script attached to planet_mesh, to get a texture image from the planet_texture node (it is a Viewport node), I should use...

var vpimg = get_node("../planet_texture").get_texture().get_data()

Right?

cybereality

If you are calling those get_nodes() on ready, then no, they are not guaranteed to be valid. The ready of each child is called, and then the parent, and then all the way up the chain. So if all the code is on planet_stuff, it will work, since you are guaranteed that both planet_texture and planet_mesh and initialized. But you cannot be guaranteed that calls between planet_texture and planet_mesh are synchronized properly because one will always be ready first, meaning communication will never work (doesn't matter which one first, since one will be valid and another invalid). So the code should be on the parent node, which is planet_stuff. Note that the texture and mesh can still have functions, but they should be called by the parent, not by themselves.

rui_mac

cybereality

Thank you very much. I will change the structure of my nodes and scripts. Unfortunately, I have to work today and I will only be able to try it later, tonight.

« Previous Page