Blender skeletal animation problem

siska

I have a rather strange problem with a skeletal animation I imported from Blender.
I'm working on a point&click game, and this particular animation is used in the inventory detail view for a book.

In the detail view, the animation seems to have always played to the end, no matter what I do (img B).
If however I detach the dv_book.tscn from the scenetree & immediately re-attach it (eg. in the _ready() ftion of the detailview), the book animation seems to behave as I expect it to behave (img A) ...

I'm wondering if there is something here that I misunderstood about how Godot does things, or if this might be some sort of bug ?

cybereality

Perhaps it's on auto-play or the loop settings are incorrect. You can also seek to the beginning of an animation and stop it there. Shouldn't be needed, but might be an okay work around if the other settings don't help. Also note that the animation current frame in the editor moves the object when you preview it and does not set it back to the original position. So it's important that the first frame of animation always is set to the base transform of the object (position or rotation, or both, depending on the animation) that way it will not be in a random place.

siska

Thanks !

Unfortunately, it doesn't seem to be any of the things you mention (I've already spent quite a bit of time on this before posting).

I have a script attachted to the imported book model with the animations ; in _ready(), I seek to frame 0.
When I play this scene (or the detailview.tscn) by itself, the animation behaves as it should.
When I play it from the game, it's not ok ... unless I detach/attach or instance a packed scene and attach that to the main tree.

cybereality

Can you post your code? I doubt it's a bug in Godot, but that is possible. Most likely it is an issue with your code. For example, expecting a certain order of _ready() calls which is not true, or the node being initialized at the incorrect time. If you want to post code, please post the text on the forum (not screenshots). You can do this by enclosing the text with 3 tildes "~~~" on a line by themselves, directly above and directly below the code. Thanks.

siska

So, this is the code attached to the book model :

func _ready():
	# anim
	ap = $AnimationPlayer
	ap.assigned_animation = "opening_strap"
	ap.seek(0,true)

The book model is included in a detail view scene (the book model, a key model, some hotspots, and another animationplayer which will coordinate the key and book animations) :

func_ready(): 
	# dv ap
	ap = $AnimationPlayer
	ap.connect("animation_finished", self, "on_anim_finished")

	book = $book_key

	key = $key
	key.hide()

	#@fixme : pages

	hs_drop = $HS_dv_drop_key
	hs_click_l = $HS_dv_btn_l
	hs_click_r = $HS_dv_btn_r

	# disable @start	
	on_item_invis()

The detail view scene responds to a change in visibility ; if invis, it simply disables all hotspots ; if vis : it checks some variables to see what animation it should display & what hotspots should be active. While trying to understand the problem I've been having, I have commented the animation bits out (to make sure they're not part of the problem).

The book detail view scene is used in the inventory detail view. It, along with some other items are all part of the invent dv scenetree, but they are invisible & inactive by default.

The invent dv visibility is toggled by the magnifier button (if an invent item is selected first) :

func _ready():
	setup()
	
	# transform magnify btn press into dv vis toggle
	GA.connect("s_toggle_dv_vis", self, "on_toggle_dv_vis") 



func setup():
	# vpc
	vpc.connect("gui_input", self, "on_gui_input")
	vpc.mouse_filter = Control.MOUSE_FILTER_STOP
	
	# vp
	vp.own_world = true 
	
	# raycast
	ray.cast_to = Vector3(0,0,-1)
	ray.collision_mask = 2
	ray.collide_with_areas = true
	ray.collide_with_bodies = false
	
	# dv items
	for c in items.get_children():
		coll_items[c.name.to_lower()] = c
	
	# hack : BUG 
	# if I don't detach from/re-attach to scenetree, 'openinig-strap anim' never on fr=0
	var hack_book_key:Spatial = $ViewportContainer/Viewport/items/book_key
	hack_book_key.get_parent().remove_child(hack_book_key)
	$ViewportContainer/Viewport/items.add_child(hack_book_key)

	# dv nfo : clear all
	reset_dv_nfo()

	#@start
	hide()

func on_toggle_dv_vis(is_vis:bool):
	# called when magnify btn is toggled
	# the dv can only open/close with decorated btn selected
	
	set_dv_nfo() # dv item and label txt to display
	
	if is_vis:
		GA.set_game_mode(GA.GAMEMODE.DV)
		
		vp.gui_disable_input = false
		cam.current = true
		ray.enabled = true
		
		show()
	
	else:
		GA.set_game_mode(GA.GAMEMODE.WORLD)
		
		vp.gui_disable_input = true
		cam.current = false
		ray.enabled = false
		
		hide()

func set_dv_nfo():
	# find correct img/model & txt
	var item_id:String = GA.get_selected_invent_item_id()
	
	show_item(item_id)
	show_label(item_id)

... I think that's all the relevant code.

Another thing I tried doing, but didn't work, is this :

func show_item(item_id:String):
	hide_all_items()
	
	var item:Spatial = coll_items.get(item_id)
	
	### other hack : doesn't work : call animplayer of book model
	if item_id.match("book_key"):
		item.book.ap.assigned_animation = "opening_strap"
		item.book.ap.seek(0,true)
	###
	
	if item is DV:
		item.enable_hs()
	item.show()

Thanks for your time !

cybereality

Okay, I see. You are never playing the animation. That property (assigned_animation) is primarily used to read the name of the current animation, not to set it. So that is the issue.

Instead of this:

ap = $AnimationPlayer
ap.assigned_animation = "opening_strap"
ap.seek(0,true)

You can do this:

ap = $AnimationPlayer
ap.play("opening_strap")
ap.stop()

siska

I'm not sure I understand what you're saying ...

I don't actually want to play the animation until I 'unlock' the book. I use seek() to set the animation to frame 0 so the strap is in the correct position ('locked'). Except, this doesn't seem to work in-game because the book in the detail view always looks like img B (unless I do that 'hack' thing). But it does work (img A) with 'play scene' (F6) ...

😀 My explanation must be very confusing ...

cybereality

No, I understand completely and I gave you the answer. Just try it.

siska

Sorry to disappoint you ... 🙂
I replaced my code with yours & removed the hacky code ... and I'm back to the problem I had before.

cybereality

Then there must be something else going on. Maybe some confusion, like calling the wrong AnimationPlayer node. I would recommend using better names like "BookAnim" to avoid confusion.

cybereality

Also, be careful the script is not calling twice. There can be a script attached to the root inside the scene, and also a script attached to the saved scene (in the parent scene) and they don't have to be the same.

siska

Yes ... somewhere I probably did something wrong ... I'll need to think about it some more.

You're right about the script thing ... definitely something to check again.