The character does not move down and up.

david8184

extends Node
var score
onready var mob_scene = preload("Mob.tscn")
func _ready():
	randomize()
	new_game()


func game_over():
	$ScoreTimer.stop()
	$MobTimer.stop()
	$HUD.show_game_over()
	$Music.stop()
	$DeathSound.play()


func new_game():
	get_tree().call_group("mobs", "queue_free")
	score = 0
	$StartTimer.start()
	$HUD.update_score(score)
	$HUD.show_message("Prepárate")


func _on_MobTimer_timeout():
	# Create a new instance of the Mob scene.
	var mob = mob_scene.instance()

	# Choose a random location on Path2D.
	var mob_spawn_location = get_node("MobPath/MobSpawnLocation")
	mob_spawn_location.offset = randi()

	# Set the mob's direction perpendicular to the path direction.
	var direction = mob_spawn_location.rotation + PI / 2

	# Set the mob's position to a random location.
	mob.position = mob_spawn_location.position

	# Add some randomness to the direction.
	direction += rand_range(-PI / 4, PI / 4)
	mob.rotation = direction

	# Choose the velocity for the mob.
	var velocity = Vector2(rand_range(150.0, 250.0), 0.0)
	mob.linear_velocity = velocity.rotated(direction)

	# Spawn the mob by adding it to the Main scene.
	add_child(mob)

func _on_ScoreTimer_timeout():
	score += 1
	$HUD.update_score(score)


func _on_StartTimer_timeout():
	$MobTimer.start()
	$ScoreTimer.start()

Megalomaniak

I'm not entirely sure this is the script responsible.

david8184

What do I have to change? Game folder.

Nerdzmasterz

Without looking at the project, the player character's script for movement is supposed to be this:

func _process(delta):
    var velocity = Vector2.ZERO # The player's movement vector.
    if Input.is_action_pressed("move_right"):
        velocity.x += 1
    if Input.is_action_pressed("move_left"):
        velocity.x -= 1
    if Input.is_action_pressed("move_down"):
        velocity.y += 1
    if Input.is_action_pressed("move_up"):
        velocity.y -= 1

    if velocity.length() > 0:
        velocity = velocity.normalized() * speed
        $AnimatedSprite.play()
    else:
        $AnimatedSprite.stop()

Make sure, however, that in your input map, you have everything spelled correctly. Note that the inputs are case-sensitive (ie move_Left is not the same as move_left).

david8184

In the end I want to use the KinematicBody2D

extends KinematicBody2D

var player: Vector2
var RUN_SPEED = 200
var stateMachine
const umbralJoystick = 0.5
onready var joystick = get_tree().get_nodes_in_group("joystick")[0].get_parent().get_node("joystick/boton")

func _ready():
	 stateMachine = $AnimationTree["parameters/playback"]

# warning-ignore:unused_argument
func _physics_process(delta):
	$boy.transform.origin.y += 1.0
	$boy.transform.origin.y -= 1.0

	player = Vector2()
	#getControlsKeyboard()
	getControlJoystick()
	print("joystick" +  str(joystick.get_value().x))
# warning-ignore:return_value_discarded
	move_and_slide(player)
	
func getControlJoystick():
	if joystick.get_value().x == 0:
		idle()
	elif joystick.get_value().x > umbralJoystick:
		correrDerecha()
	elif joystick.get_value().x < umbralJoystick:
		correrIzquierda()
	elif joystick.get_value().x > umbralJoystick:
		correrAbajo()
	elif joystick.get_value().x > umbralJoystick:
		correrArriba()


#Controlamos al personaje con el teclado
func getControlsKeyboard():
	if Input.is_action_pressed("ui_right"):
		correrDerecha()
	elif Input.is_action_pressed("ui_left"):
		correrIzquierda()
	if Input.is_action_pressed("move_down"):
		correrAbajo()
	elif Input.is_action_pressed("move_up"):
		correrArriba()

	
func idle():
	stateMachine.travel("idle")
	
func correrDerecha():
	stateMachine.travel("run")
	player.x += RUN_SPEED
	$boy.scale.x = 1

func correrIzquierda():
	player.x -= RUN_SPEED
	$boy.scale.x = -1

func correrAbajo():
	stateMachine.travel("run")
	player.x += RUN_SPEED
	$boy.scale.y = 1

func correrArriba():
	player.x -= RUN_SPEED
	$boy.scale.y = -1

david8184

But does not move up and down.

Nerdzmasterz

func getControlsKeyboard():
    if Input.is_action_pressed("ui_right"):
        correrDerecha()
    elif Input.is_action_pressed("ui_left"):
        correrIzquierda()
    if Input.is_action_pressed("move_down"):
        correrAbajo()
    elif Input.is_action_pressed("move_up"):
        correrArriba()

Are you using the inputs called "move_up" and "move_down", or "ui_up" and "ui_down"?

david8184

What it is better?

Nerdzmasterz

On the input map, you map out the inputs. the inputs on the map have to be exactly as what is used in the code.

david8184

This is the main map.

extends Node
var score
onready var mob_scene = preload("Mob.tscn")
func _ready():
	randomize()
	new_game()


func game_over():
	$ScoreTimer.stop()
	$MobTimer.stop()
	$HUD.show_game_over()
	$Music.stop()
	$DeathSound.play()


func new_game():
	get_tree().call_group("mobs", "queue_free")
	score = 0
	$StartTimer.start()
	$HUD.update_score(score)
	$HUD.show_message("Prepárate")


func _on_MobTimer_timeout():
	# Create a new instance of the Mob scene.
	var mob = mob_scene.instance()

	# Choose a random location on Path2D.
	var mob_spawn_location = get_node("MobPath/MobSpawnLocation")
	mob_spawn_location.offset = randi()

	# Set the mob's direction perpendicular to the path direction.
	var direction = mob_spawn_location.rotation + PI / 2

	# Set the mob's position to a random location.
	mob.position = mob_spawn_location.position

	# Add some randomness to the direction.
	direction += rand_range(-PI / 4, PI / 4)
	mob.rotation = direction

	# Choose the velocity for the mob.
	var velocity = Vector2(rand_range(150.0, 250.0), 0.0)
	mob.linear_velocity = velocity.rotated(direction)

	# Spawn the mob by adding it to the Main scene.
	add_child(mob)

func _on_ScoreTimer_timeout():
	score += 1
	$HUD.update_score(score)


func _on_StartTimer_timeout():
	$MobTimer.start()
	$ScoreTimer.start()

david8184

@Nerdzmasterz said: func getControlsKeyboard(): if Input.is_action_pressed("ui_right"): correrDerecha() elif Input.is_action_pressed("ui_left"): correrIzquierda() if Input.is_action_pressed("move_down"): correrAbajo() elif Input.is_action_pressed("move_up"): correrArriba()

Are you using the inputs called "move_up" and "move_down", or "ui_up" and "ui_down"?

But I did with ui and move and do not move up and down.

Nerdzmasterz

OK, I will make this simple. Go to project -> project settings. In the project settings, there is a tab titled input maps. Click that, and see what the inputs for up and down are called. The inputs on that tab must match the input names on Input.is_action_pressed().

Kojack

func getControlJoystick():
    if joystick.get_value().x == 0:
        idle()
    elif joystick.get_value().x > umbralJoystick:
        correrDerecha()
    elif joystick.get_value().x < umbralJoystick:
        correrIzquierda()
    elif joystick.get_value().x > umbralJoystick:
        correrAbajo()
    elif joystick.get_value().x > umbralJoystick:
        correrArriba()

Your up and down calls are using the joystick x axis instead of y. Both up and down are also doing greater than umbralJoystick, if the range of the joystick is -1 to 1 then one of them should be < -umbralJoystick.

func correrAbajo():
    stateMachine.travel("run")
    player.x += RUN_SPEED
    $boy.scale.y = 1
func correrArriba():
    player.x -= RUN_SPEED
    $boy.scale.y = -1

Both up and down functions are adding to the player.x instead of player.y.

david8184

So? The player does not move up and down.

extends KinematicBody2D

var player: Vector2
var RUN_SPEED = 200
var stateMachine
const umbralJoystick = 0.5
onready var joystick = get_tree().get_nodes_in_group("joystick")[0].get_parent().get_node("joystick/boton")

func _ready():
	 stateMachine = $AnimationTree["parameters/playback"]

# warning-ignore:unused_argument
func _physics_process(delta):
	$boy.transform.origin.y += 1.0
	$boy.transform.origin.y -= 1.0

	player = Vector2()
	#getControlsKeyboard()
	getControlJoystick()
	print("joystick" +  str(joystick.get_value().x))
# warning-ignore:return_value_discarded
	move_and_slide(player)
	
func getControlJoystick():
	if joystick.get_value().x == 0:
		idle()
	elif joystick.get_value().x > umbralJoystick:
		correrDerecha()
	elif joystick.get_value().x < umbralJoystick:
		correrIzquierda()
	elif joystick.get_value().x > umbralJoystick:
		correrAbajo()
	elif joystick.get_value().x > umbralJoystick:
		correrArriba()


#Controlamos al personaje con el teclado
func getControlsKeyboard():
	if Input.is_action_pressed("move_right"):
		correrDerecha()
	elif Input.is_action_pressed("move_left"):
		correrIzquierda()
	if Input.is_action_pressed("move_down"):
		correrAbajo()
	elif Input.is_action_pressed("move_up"):
		correrArriba()
	
func idle():
	stateMachine.travel("idle")
	
func correrDerecha():
	stateMachine.travel("run")
	player.x += RUN_SPEED
	$boy.scale.x = 1

func correrIzquierda():
	player.x -= RUN_SPEED
	$boy.scale.x = -1

func correrAbajo():
	stateMachine.travel("run")
	player.x += RUN_SPEED
	$boy.scale.y = 1
func correrArriba():
	player.x -= RUN_SPEED
	$boy.scale.y = -1

Kojack

@david8184 said: So? The player does not move up and down. Just in case there was a confusion, the code I posted was the code that was incorrect, not replacement working code.

All of your up and down code is using x (which is left and right) instead of y (which is up and down). For example, the correrArriba function is doing player.x -=RUN_SPEED. But player.x is their horizontal movement, subtracting from it moves you to the left, not up. That should be player.y.

david8184

So?

extends KinematicBody2D

var player: Vector2
var RUN_SPEED = 200
var stateMachine
const umbralJoystick = 0.5
onready var joystick = get_tree().get_nodes_in_group("joystick")[0].get_parent().get_node("joystick/boton")

func _ready():
	 stateMachine = $AnimationTree["parameters/playback"]

# warning-ignore:unused_argument
func _physics_process(delta):
	$boy.transform.origin.y += 1.0
	$boy.transform.origin.y -= 1.0

	player = Vector2()
	#getControlsKeyboard()
	getControlJoystick()
	print("joystick" +  str(joystick.get_value().x))
# warning-ignore:return_value_discarded
	move_and_slide(player)
	
func getControlJoystick():
	if joystick.get_value().x == 0:
		idle()
	elif joystick.get_value().x > umbralJoystick:
		correrDerecha()
	elif joystick.get_value().x < umbralJoystick:
		correrIzquierda()
	elif joystick.get_value().y > umbralJoystick:
		correrAbajo()
	elif joystick.get_value().y > umbralJoystick:
		correrArriba()


#Controlamos al personaje con el teclado
func getControlsKeyboard():
	if Input.is_action_pressed("move_right"):
		correrDerecha()
	elif Input.is_action_pressed("move_left"):
		correrIzquierda()
	if Input.is_action_pressed("move_down"):
		correrAbajo()
	elif Input.is_action_pressed("move_up"):
		correrArriba()
	
func idle():
	stateMachine.travel("idle")
	
func correrDerecha():
	stateMachine.travel("run")
	player.x += RUN_SPEED
	$boy.scale.x = 1

func correrIzquierda():
	player.x -= RUN_SPEED
	$boy.scale.x = -1

func correrAbajo():
	stateMachine.travel("run")
	player.y += RUN_SPEED
	$boy.scale.y = 1
func correrArriba():
	player.y -= RUN_SPEED
	$boy.scale.y = -1

Nerdzmasterz

I would like to know what the keyboard and joystick inputs actually do? Do they simply have the character stay put? Does it make them move left and right instead? Do they do anything?

fire7side

@Nerdzmasterz said: I would like to know what the keyboard and joystick inputs actually do? Do they simply have the character stay put? Does it make them move left and right instead? Do they do anything?

Kojack identified the problem, he just has to do what he told him to do.

david8184

This is the script of the joystick.

extends TouchScreenButton

var radio = Vector2(24,24)
var limite= 24
var marcha = -1
var volver = 20
var limite2 = 10

func _physics_process(delta):
	if marcha == -1:
		var pos_difference = (Vector2(0, 0) - radio) - position
		position += pos_difference * volver * delta
		
func get_button_pos():
	return position + radio
	
func _input(event):
	if event is InputEventScreenDrag or (event is InputEventScreenTouch and event.is_pressed()):		
		var distCentre = (event.position - get_parent().global_position).length()				
		if distCentre <= limite * global_scale.x or event.get_index() == marcha:
			set_global_position(event.position - radio * global_scale)
			if get_button_pos().length() > limite:
				set_position( get_button_pos().normalized() * limite - radio)	
			marcha = event.get_index()	
	if event is InputEventScreenTouch and !event.is_pressed() and event.get_index() == marcha:
		marcha = -1	
	
func get_value():
	if get_button_pos().length() > limite2:
		return get_button_pos().normalized()
	return Vector2(0, 0)

david8184

@fire7side said:

@Nerdzmasterz said: I would like to know what the keyboard and joystick inputs actually do? Do they simply have the character stay put? Does it make them move left and right instead? Do they do anything?

Kojack identified the problem, he just has to do what he told him to do.

I did what he told me.