KinematicBody2D not updating position despite boolean telling it to

Lethn

 func NPCPatrolMovement():
	if HasRepublicShipEnteredPatrolPoint1 == false: 
		transform.origin = transform.origin.move_toward(PatrolPathPoint1.position, 3)
	if HasRepublicShipEnteredPatrolPoint1 == true:
		transform.origin = transform.origin.move_toward(PatrolPathPoint2.position, 3)
	if HasRepublicShipEnteredPatrolPoint2 == true:
		transform.origin = transform.origin.move_toward(PatrolPathPoint3.position, 3)

I whipped up what I thought was a basic waypoint system after doing some digging around and for some reason the ship just won't move past the second patrol point despite the boolean being true. The idea is straight forward, the ship goes towards the patrol point which is an area2D, the area2D sends a signal to the ship and updates the boolean so the ship knows to carry on to the next patrol point in the sequence.

The third patrol point however isn't updating correctly for whatever reason despite the booleans working fine and I did double check with print. I don't think there are any problems with my signal setup or my group setups that I've used to grab the patrol points.

Here's a visual aid of what's going on, the ship that is moving is the yellowish ship, the red path is current path, the green path is what I'm trying to achieve, would be great if I could get some help on this as I'm a bit baffled as to why the code is ending too soon.

RichNaoo

When your ship has entered the 2nd patrol point the ship's HasRepublicShipEnteredPatrolPoint1 gets set to true, the way your if statements work is check if HasRepublicShipEnteredPatrolPoint1 == false then check if HasRepublicShipEnteredPatrolPoint1 == true and only then will it check for the HasRepublicShipEnteredPatrolPoint2's value. So even if HasRepublicShipEnteredPatrolPoint2 == true it will always succeed on one of the conditions for HasRepublicShipEnteredPatrolPoint1 thus never check HasRepublicShipEnteredPatrolPoint2.

To fix this you simply have to check the patrolpoints in reverse order so you are sure you'll always check the latest possible patrolpoint first.

Lethn

Thank you, that makes sense, will try that and see what happens, classic execution order issue.

Lethn

func NPCPatrolMovement():
	if HasRepublicShipEnteredPatrolPoint2 == true:
		transform.origin = transform.origin.move_toward(PatrolPathPoint3.position, 3)
	elif HasRepublicShipEnteredPatrolPoint1 == true:
		transform.origin = transform.origin.move_toward(PatrolPathPoint2.position, 3)
	elif HasRepublicShipEnteredPatrolPoint1 == false: 
		transform.origin = transform.origin.move_toward(PatrolPathPoint1.position, 3)

Aha! It worked! I did what you suggested with if statements only but it looks like else if are what did the trick with the order, I now have a patrol path for my spaceship! Thanks!

For those curious, heres the code for the NPC spaceship.

extends KinematicBody2D

var HasRepublicShipEnteredPatrolPoint1 = false
var HasRepublicShipEnteredPatrolPoint2 = false
var HasRepublicShipEnteredPatrolPoint3 = false

onready var patrolPathGroup1 = get_tree().get_nodes_in_group("FreeRepublicPath_1_1")
onready var PatrolPathPoint1 = patrolPathGroup1[0]

onready var patrolPathGroup2 = get_tree().get_nodes_in_group("FreeRepublicPath_1_2")
onready var PatrolPathPoint2 = patrolPathGroup2[0]

onready var patrolPathGroup3 = get_tree().get_nodes_in_group("FreeRepublicPath_1_3")
onready var PatrolPathPoint3 = patrolPathGroup3[0]

func _physics_process(delta):
	NPCPatrolMovement()
	
func NPCPatrolMovement():
	if HasRepublicShipEnteredPatrolPoint2 == true:
		transform.origin = transform.origin.move_toward(PatrolPathPoint3.position, 3)
	elif HasRepublicShipEnteredPatrolPoint1 == true:
		transform.origin = transform.origin.move_toward(PatrolPathPoint2.position, 3)
	elif HasRepublicShipEnteredPatrolPoint1 == false: 
		transform.origin = transform.origin.move_toward(PatrolPathPoint1.position, 3)

RichNaoo

Oh right you'd have to either use elif's or guard clauses, nicely done!

Megalomaniak

I suspect this might be a really good case for match

https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_basics.html#match