onready var node != get_node(node_name)?

Nerdzmasterz

I've seen other people use onready var tree_sprout = get_node("node_name"), and it works. When I do it, it doesn't and I have to type outget_node whatever all the time.

Any idea why?

DaveTheCoder

Are you sure that "node_name" is the correct path to the node, either an absolute path, or a path relative to the node to which the script is attached?

Also, the node must be in the scene tree . I.e., if that code is in node A and references node B, then B must be in the scene tree when A's ready() is called by the engine. Normally that means that B must be a descendant of A.

I prefer using the $ syntax, but haven't had any problems with it. For example: onready var gui_pause_button: Node = $Game/GUI/PauseButton

Nerdzmasterz

Yes. I dragged and dropped each node in.

DaveTheCoder

Could you post a minimal project that illustrates the problem?

Nerdzmasterz

    onready var tree_sprout = get_node("SpriteSprout")
    onready var tree_young = get_node("Sprite_young")
    onready var tree_Area = get_node("Area2D_Tree")
    onready var tree_green = get_node("Area2D_Tree/SpriteTree")
    onready var tree_fruit_young = get_node("Area2D_Tree/SpriteFruit")
    onready var tree_fruit_mature = get_node("Area2D_Tree/SpriteFruit/Sprite_Fruit_Mature")
    onready var tree_dead = get_node("Area2D_Tree/SpriteDead")
func hide_all():
	get_node("SpriteSprout").hide()
	get_node("Sprite_young").hide()
	get_node("Area2D_Tree").hide()
	get_node("Area2D_Tree/SpriteTree").hide()
	get_node("Area2D_Tree/SpriteFruit").hide()
	get_node("Area2D_Tree/SpriteFruit/Sprite_Fruit_Mature").hide()
	get_node("Area2D_Tree/SpriteDead").hide()

I had to change the whole bottom part as it wasn't working.

DaveTheCoder

By posting a minimal project, I meant posting a .zip containing a project folder, which someone could download to see the error and its cause.

Nerdzmasterz

Here it is.

Nerdzmasterz

Afraid I don't know how to minimize the project yet. It's complex and sending a little bit of it might break it.

DaveTheCoder

What do I do to see an error, or something that's not working?

Nerdzmasterz

I'm assuming you switched a few nodes to another name in the code? That's the thing. I see no errors when I do it, either. It's very odd. It just acts like I never called the node.

DaveTheCoder

Could you provide a specific example? To answer your original question, I need to see exactly what code is causing an issue.

Nerdzmasterz

Any time I don't use get_node(whatever), it didn't work. Ie, I originally had this under hide_all().

func hide_all():
	tree_sprout.hide()
	tree_young.hide()
	tree_Area.hide()
	tree_green.hide()
	tree_fruit_young.hide()
	tree_fruit_mature.hide()
	tree_dead.hide()

It didn't do anything.

Nerdzmasterz

If you for some reason you press play and notice the zombies in the game, they're still a little buggy. I'm not done with them just yet.

cybereality

You can't just call code loose at the stop. It should be in the _ready() function at the soonest. Onready keyword is special in that it gets called before ready and is mainly used to setting node references. But you can't just call code or things at the top outside of functions, it won't work.