Animations Only Work for first instance

friendMaster2000

I'm having a problem with animations.

So I created a zombie scene which includes a mesh and animation player with animations. I add the zombie scene to the level and animations work fine. However, when I add a second instance of the same zombie scene, animations don't run for it. I read about it and it looks like both scenes are sharing the same animations/player? How do I get each instance of the zombie scene to use it's own animations and animation player?

I opened the zombie scene as a resource and checked the box for local to scene but I'm still getting the same issue. Why is such a simple thing not working in this engine?

fire7side

The animations should work. You might be adding the same instance or something. I just instanced a moving animation and it worked fine. var instance0 = obj.instance() add_child(instance0) var instance1 = obj.instance() add_child(instance1)

That sounds obvious, but I don't know why it would do it. I have an object that targets the player and shoots bullets and they work independently. I didn't make them unique or anything. I just wrote it verbose like that to be clear you have to re-instance the object each time.

Check the docs on instancing. I would also get the translation or position you want and do it in code rather than in the editor, if you are doing that. It should work, but it gets messy.

Make sure when you import you make a new inherited scene.

friendMaster2000

@fire7side said: The animations should work. You might be adding the same instance or something. I just instanced a moving animation and it worked fine. var instance0 = obj.instance() add_child(instance0) var instance1 = obj.instance() add_child(instance1)

That sounds obvious, but I don't know why it would do it. I have an object that targets the player and shoots bullets and they work independently. I didn't make them unique or anything.

Check the docs on instancing.

I'm not instancing the scenes through code. I'm just adding both scene instances to the level in the editor. Animations work for whichever instance is first in the scene outliner. Scenes the come afterward just T-pose in the game.

The hover tooltip in first two screens show theyre both instances of the same scene.

Second instance is the same scene file:

At runtime only one scene displays animations:

I cant figure out the problem here. I've tried to open the zombie scene as a resource and click the "Local to Scene" checkbox but still not working.

After I couldnt get it to work for awhile and doing some research, I've even tried duplicating the animation player and animations using the code below:

animPlayer = target.get_node(AnimPlayer) if animPlayer: var animPlayerDup: AnimationPlayer = animPlayer.duplicate() var animList = animPlayer.get_animation_list() for animationName in animList: var animation: Animation = animPlayer.get_animation(animationName) animPlayerDup.add_animation(animationName, animation.duplicate()) animPlayer = animPlayerDup

I added proper indentation, debugged the code until there's no errors, and everything seems to be fine but the problem still exists. Why am I having so much trouble with something so simple?

fire7side

If you double click on the scene file in the main, the little gate with arrow down, it should open up the scene file of the duplicate. You will find the animation player there. Click on the animation player in the ones that don't do anything and it will say current animation in the window on the right. Make sure that is set to an animation like idle. You should be able to select each animation in the animation player window and play the animations. From what you've said. I would delete the duplicates and then reduplicate the original by right clicking and selecting duplicate. Then if they don't play, double click on the scene files of the duplicates and check the animation player.

friendMaster2000

A reddit user helped me solve the issue. I had to take both scenes and use Make Local for the animations to work in the second scene.

For anyone that's interested...When I right-click each of the scene instances in the scene outliner, and I choose "Make local" it breaks the scene down so that local duplicates of the scene's node network are added directly into the scene. Now it's no longer using the scene, it's using a local node-wise copy of the scene. Therefore, I see that technically there really is no way to do this with scenes, which is fine with me. The animations work fine now and I can move on with my game.

fire7side

I don't know why you would have to do that in the scene editor but not in code. At some point you aren't going to be wanting to spawn enemies by placing them that way in the scene editor, but you got it working anyway.

edit: I just dragged a couple animated character scenes into my scene main and they both work fine, independently aim at my character, animate, and both shoot at me, same as in code. I suspect it has something to do with your duplication method or the way you made your scene. I know when you import, you have to choose new inherited and make a separate scene. It's not a big deal right now, anyway.

friendMaster2000

@fire7side said: I don't know why you would have to do that in the scene editor but not in code. At some point you aren't going to be wanting to spawn enemies by placing them that way in the scene editor, but you got it working anyway.

edit: I just dragged a couple animated character scenes into my scene main and they both work fine, independently aim at my character, animate, and both shoot at me, same as in code. I suspect it has something to do with your duplication method or the way you made your scene. I know when you import, you have to choose new inherited and make a separate scene. It's not a big deal right now, anyway.

I would really like to get to the bottom of this problem I'm having. I'm experimenting with spawning scenes into the level dynamically through code and I'm having the same issue with animations only working for the first scene instance that gets spawned. I would like to know what I'm doing(or not doing) that's making the scenes share the same animation resource.

Here's how I'm spawning the scenes. Pay no attention to tabs everythings formatted correctly:

scene file is preloaded by a separate script:

var resource: Dictionary = {
	"zombieScene": preload("res://scenes/dynamic/zombieb/zombieb.tscn")
	}

Scene instance is instantiated in another script:
```
var objInst = resource["zombieScene"].instance()
```
Another scene is instantiated using the same script:
```
var objInst = resource["zombieScene"].instance()
```

This is the how I'm instancing the scenes. There's not much more to it.

For playing the animation, there's an exported var called AnimPlayer. It's a node path.

export(NodePath) var AnimPlayer

When editing the zombie scene, I click this field in the editor and from the node selection menu, I then click the animation player to give it the correct node path to use. A separate variable(animPlayer) is used to reference the Animationplayer node. This code is used to reference the animation player node:

if AnimPlayer:
		animPlayer = get_node(AnimPlayer)

Here's how the zombie scene is composed if this helps:

-zombie(kinematic body scene root) -StateMachine -CollisionShape -mesh -Skeleton -AnimationPlayer

Here is the function being used for playing the zombies' animation. I added a debug message:

func playAnimation(name: String,   custom_blend: float = -1, custom_speed: float = 1.0, from_end: bool = false):
	print("playing animation player node: %s for %s"%[animPlayer.get_instance_id(), name])
	animPlayer.play(name, custom_blend, custom_speed, from_end)

In the console, I see two print statements:

playing animation player node: 5071 for Walking playing animation player node: 5071 for Walking

The two print statements indicate that the "Walking" animation is being called twice but each time for the same AnimationPlayer instance. You can tell by the identical animation player instance Id even though two scenes are being spawned.

I have also loaded the zombie scene and each animation file in the resource editor and checked "Local to scene". And this problem persists. Keep in mind this is for a 3d game with 3d meshes and animations.

I feel like I have been fighting against Godot's tendency to share animation resources for the last two days now and it's getting very tiresome. Any help or feedback would be great.

fire7side

I would just start with the model import and make a simple scene with kinematic body. Is it a glb or what? Right click and make a new inherited scene. It will make it a spatial, but you can change the type, or you can add the scene to a kinematic body. Then just try to reference the animation player from a script on the kinematic body scene. Don't paste in path, just reference it with the editor and get_node. It will show the options and pick the animation player. Then make a main scene and drag it into it and see if it duplicates. Assuming it does, try to add pieces one at a time.

friendMaster2000

I finally fixed this issue. Thanks @fire7side for the help. You got me thinking about things in a different way and I realized how my approach was wrong.

All instances of scenes do have their own animations and animation players. The problem was my script that's used for their state machine implementation. This script isn't attached to a node, instead it's being loaded from file as a resource. This script resource was actually being shared among instances of the same scene. Different scenes get their own duplicate of the script, but different instances of the same scene is sharing the same script resource. So changes to the script in one scene instance was affecting the same loaded script in other instances of the same scene.

Once I realized this I was able to change the state machine script to accomodate it being shared between multiple instances of the scene and now everything's working fine. I'm still not sure if instances of a loaded script should be shared among instances of a scene, but whatever, at least it's working now =)

fire7side

Well, you got it working. The more you work with it, the more you learn. There's no right or wrong way. If it works it works. Glad you can move on with your project.