body entered working fine, but some minutes later for some reason working body exited.

Hramzhuk

Hi! I try to make basic collisions in my game. I make variable 'collides' and it changes to true if body_entered() and false if body_exited() then loop check variable's value and if it true then plus coordinate y on 1. But when i test it player some minutes player don't fall but some minutes later he's fall from map. What's wrong? Here's my code:

extends Node2D

var jumpMinWidth = 100
var jumpMaxWidth = 400
var score = 0
var objectsCount = 0
var collides = false
onready var waterLily = get_node("/root/Main/WaterLilyExample")
onready var reeds = get_node("/root/Main/ReedsExample")
onready var sky = get_node("/root/Main/Sky")
onready var player = get_node("/root/Main/Player")

func infinityMapGeneration():
	objectsCount += 1
	sky.scale.x += 200
	print(collides)
	if main.collides == false:
		player.position.y += 1
	var rng = RandomNumberGenerator.new()
	rng.randomize()
	var myRandomNumber = round(rng.randf_range(1, 2))
	if myRandomNumber == 1:
		var waterLilyClone = waterLily.duplicate()
		add_child(waterLilyClone)
		rng.randomize()
		myRandomNumber = round(rng.randf_range(jumpMinWidth * 3, jumpMaxWidth))
		waterLilyClone.position.x += myRandomNumber
		waterLily.position = waterLilyClone.position
		reeds.position = waterLilyClone.position
		waterLilyClone.visible = true
		waterLilyClone.name = "WaterLily" + str(objectsCount)
	else:
		var reedsClone = reeds.duplicate()
		add_child(reedsClone)
		rng.randomize()
		myRandomNumber = round(rng.randf_range(jumpMinWidth * 3, jumpMaxWidth))
		reedsClone.position.x += myRandomNumber
		rng.randomize()
		myRandomNumber = round(rng.randf_range(-jumpMinWidth * 3, jumpMaxWidth - 200))
		reedsClone.position.y += myRandomNumber
		reeds.position = reedsClone.position
		waterLily.position = reedsClone.position
		reedsClone.visible = true
		reedsClone.name = "Reeds" + str(objectsCount)
	get_node("/root/Main/Timer").start(0.1)

Hramzhuk

I know my error. Godot docs says OVERLAPS not COLLISION.

Megalomaniak

_ready() is typically only called once so I'm not sure that using a while loop in it makes much sense, just a thought.

Hramzhuk

Ok, but what do you think on my problem?

Megalomaniak

Your while is not only inside a function that is called one time right after a node enters a scene and becomes 'ready' you also forgot to add the variant collides in there so it's just while true with no guidance given to godot about what should be true.

So try changing the while line to while collides: and rename the governing func to something else then call that function from a relevant place.

Hramzhuk

Okay, i maked function with my loop and called it from _ready function. While true think that in many programming languanges it mean fake infinite loop. My map generates infinite so if i make that map would be not infinite.

Megalomaniak

Stop calling it from ready(). Sounds like you might be better off with a Timer - lets call it MapGenTimer and a on_timer_timeout() signal from it calling the code/function.

And remove the while loop. Instead you can restart the timer at the end of the function/code so it will effectively loop.

Hramzhuk

Yes, i maked how you sayed and it working. But this forum's theme was another.

Megalomaniak

@Hramzhuk said: But this forum's theme was another.

Not sure I understand, can you rephrase it?

edit: if you mean the subject was different, then yeah, I thought you already resolved it with respect to the post about overlaps.

Hramzhuk

But it working strange... Signal body entered working but later signal body exited working.

Hramzhuk

And maybe i make something wrong? And it worked if i don't make something wrong?

Megalomaniak

@Hramzhuk said: But it working strange... Signal body entered working but later signal body exited working.

Are you saying at some point you don't want body exited signal to work? You could try disconnecting the signal I suppose, but more likely you'll want to have a state variable that can be checked upon body exited signal firing to determine if some code path should be processed or not.