how to set height of collsionshape3D by script?

DJM

how can i modify the height of a collisionshape3D?

func crouch():
	if iscrouching:
		#how to set height?
		#collisionshape.height = crouchheight
		#camera doesnt get updated either
		$CamRoot.transform.origin.y = crouchcameraheight
	else:
		#collisionshape.height = normalheight
		$CamRoot.transform.origin.y = normalcameraheight

GlyphTheWolf

Hi,

That probably depends on shape you use. Assuming you use sphere for example you could edit radius by:

$CollisionShape.shape.radius = newRadius

I know you're not using sphere, but it's just example because I remember it have radius parameter. For other shapes you need to check it parameters.

Also remember that only changing height will probably make your shape shorter at the top and at the bottom equally, so probably you also should move it down (half the value of height you substracted).

Edit: at least that is how it worked for godot 3.x I don't know if there are differences for godot 4.

DJM

hi that doesnt give errors in godot 4 however the func doesnt seem to get called

#this is in process
if Input.is_action_just_pressed("crouch") and is_on_floor() :
		iscrouching = !iscrouching

if iscrouching != iscrouching:
		crouch()

func crouch():
	if iscrouching:
		
		collisionshape.shape.height = crouchheight
		$CamRoot.transform.origin.y = crouchcameraheight
	else:
		collisionshape.shape.height = normalheight
		$CamRoot.transform.origin.y = normalcameraheight

GlyphTheWolf

if iscrouching != iscrouching:

Isn't that this if is never true?

DJM

@GlyphTheWolf said:
if iscrouching != iscrouching:
Isn't that this if is never true? no it does get stated true, setting the speed works in my script the func that does the capsule and camera height doesnt get triggered
elif  iscrouching:
		wantedspeed = CROUCH_SPEED

GlyphTheWolf

But is your speed also set inside crouch() func?

I can't see this able to execute:

if iscrouching != iscrouching:
        crouch()

It's condition like if 1 != 1 and that is always false.

DJM

no speed isnt set in crouch func so how do i check if in crouching mode?

DJM

this seems to work

if iscrouching != !iscrouching:

but i have no idea why

GlyphTheWolf

I think it should be just:

if Input.is_action_just_pressed("crouch") and is_on_floor() :
        iscrouching = !iscrouching
        crouch()

That way it should be called when crouch mode is changed and inside of crouch() func you check current crouching mode anyway, so it should work fine.

DJM

tnx! works fine

DJM

if i set the collisionshape position when crouching/uncrouching the camera set position stops working. why is that?

func crouch():
	if iscrouching:
		
		collisionshape.shape.height = crouchheight
		#if i remove this line camera position set works>
		#collisionshape.transform.origin.y -= normalheight - crouchheight
		$CamRoot.transform.origin.y = crouchcameraheight
	else:
		
		collisionshape.shape.height = normalheight
		#if i remove this line camera position set works>
		#collisionshape.transform.origin.y += normalheight - crouchheight
		$CamRoot.transform.origin.y = normalcameraheight

DJM

no one has an idea why this is happening?

cybereality

You cannot change the shape of collision objects at run time cause it messes up the physics engine (many things are pre-computed). What you want to do is have 2 separate shapes you design in the GUI and simply enable/disable them at the right time.

DJM

ok will try it

DJM

@cybereality said: You cannot change the shape of collision objects at run time cause it messes up the physics engine (many things are pre-computed). What you want to do is have 2 separate shapes you design in the GUI and simply enable/disable them at the right time.

works fine now, tnx!