delete object when visibilitynotifier camera exited?

DJM

this script used to work in godot3 the visibility notifier when camera exited doesnt seem to do anything anymore i probably need another func

extends RigidDynamicBody3D


@export var shellSounds : Array[AudioStreamSample]
@export var myAudioStream_path: NodePath
#@export var shellmesh_path: NodePath
#@onready var shellmesh = get_node(shellmesh_path)
@onready var myAudio = get_node(myAudioStream_path)
var random = RandomNumberGenerator.new()
func _ready():
	add_to_group("ignore")
	random.randomize()

#this doesnt work anymore in godot4
func _on_VisibilityNotifier_camera_exited(_camera):
	self.queue_free()


func _on_pistolshell_body_entered(_body):
	#shellmesh.set_layer_mask(1)
	var n = randi() % (shellSounds.size() - 1) + 1
	myAudio.stream = shellSounds[n]
	myAudio.pitch_scale = random.randf_range(0.9, 1.1)
	if myAudio.playing  == false:
		myAudio.play()

Megalomaniak

Are you sure the visibility_changed() signal is actually connected?

DJM

@Megalomaniak said: Are you sure the visibility_changed() signal is actually connected?

aha , so its called visibility changed now? ive seen it in the node signals but i have no idea what to pass in to it

also is there a way of calling body_entered into some more generic function and not scene specific? this way i can use the "shell" script for all shells. now i need to assign a node signal specific to every node.seems a bit weird to have multiple scripts that actually all do the same except calling the nodes specific name body_entered func

Megalomaniak

Hmm, well it's called that in 3.4.0 as well so I don't think it has changed, meaning I might have misunderstood what _on_VisibilityNotifier_camera_exited(_camera): is in your code.

DJM

@Megalomaniak said: Hmm, well it's called that in 3.4.0 as well so I don't think it has changed, meaning I might have misunderstood what _on_VisibilityNotifier_camera_exited(_camera): is in your code.

if i remember well, it was a node signal u could pass to an object. i dont see it anymore in godot4. but doesnt matter, if i can use visibility changed thats fine. how do i "self.queue_free()"when object is out of view and away from player?

Megalomaniak

Ah, right. So VisibilityNotifier is a node of it's own, and inherits from spatial which was renamed Node3D for consistency so VisibilityNotifier also got renamed to VisibilityNotifier3D. You'll want to make sure you have that node in your scene and that it's relevant signal is connected.

DJM

apparently its called "visible on screen notifier" so i added the node and passed the signal _on_visible_on_screen_notifier_3d_screen_exited(): delete object from scene

works fine now tnx!

what about the generic onbody_entered func? does it really have to be scene specific to pass that signal?

Megalomaniak

The pistolshell one looks like it might be from a mesh instance or a collider or such.

DJM

@Megalomaniak said: The pistolshell one looks like it might be from a mesh instance or a collider or such.

yes its a signal attached to a rigiddynamicbody3D , is there a way to detect collisions without connecting a signal?

Megalomaniak

Perhaps by using/polling the physics server directly? I've always just relied on the signals tho.

cybereality

You should probably consult the documentation more. I understand you are an artist and not a programmer, but it's a good investment to learn. Also, because Godot 4.0 is so new, no one really knows how it works. So you'll have to figure out a lot on your own.

DJM

@cybereality said: You should probably consult the documentation more. I understand you are an artist and not a programmer, but it's a good investment to learn. Also, because Godot 4.0 is so new, no one really knows how it works. So you'll have to figure out a lot on your own.

yes i suck at coding ive found the docs arent always up to date. im just asking for advice, nothing wrong with that right?

cybereality

Yeah, it's all good. I'm just letting you know that no one (except maybe the people that made Godot) know the answer. I had to figure out basically everything myself, there weren't even hits on Google.

DJM

@cybereality said: Yeah, it's all good. I'm just letting you know that no one (except maybe the people that made Godot) know the answer. I had to figure out basically everything myself, there weren't even hits on Google.

not everyone has the coding skills to figure things out on their own like u. i think thats why a forum/community is necessary to people who are learning the engine(like me ;) )

cybereality

Good point. It wasn't easy for me either.