Why is my spawner creating just one child?

UrielP

Hi! I'm new in Godot and I'm trying to recreate a Tetris game. I saw a Unity tutorial and I want to do something similar with Godot. The problem that I have is, that my spawner creates just one Tetromino as a child and nothing more. I'm using a custom signal to tell the "Game" node (main), that a Tetromino can't move anymore and should add another child to the game. I guess this is because I added a set_process(false), but I don't understand why this should affect all the instantiated scenes too. Anyway, here's my code:

Game (main):

func _ready():

makeTetromino()
$BlockT.connect("newT", self ,"makeTetromino")

func makeTetromino():

var scene = load("res://BlockT.tscn")
var instance = scene.instance()
instance.position = Vector2(486,57)
add_child(instance)

BlockT (tetromino):

func _process(delta):

var x = timeFall/15 if Input.is_action_pressed("ui_down") else timeFall
if(OS.get_ticks_msec() - start > x):
	self.position.y += unity
	start = OS.get_ticks_msec()
	if(!canMove()):
		self.position.y -= unity
		emit_signal("newT")
		set_process(false)

func canMove():

for child in self.get_children():
	var x = child.get_global_position().x
	var y = child.get_global_position().y
	if(int(x) < 0 or int(x) > width*unity or int(y) >= height*unity):
		return false
return true`

PD. I tried to do it too with a timer and at the end delete it, so the tetromino stops moving, but I got the same result. What am I doing wrong? Thanks!

cybereality

Why would you set process to false? This basically disables the node.

UrielP

So the tetromino can't move anymore. But as I said, I tried too with a timer instead of setting the process to false and I get the same results. And when I just delete the set process function, a lot of tetrominos are created in just a second and the movement affects to everyone, so I don't know how to "disable" the one who just touched the floor and still keep spawning. Any ideas?

cybereality

So to answer you question, I believe if you click the "local to scene" checkbox on the block node in the Inspector, this will separate the blocks so they don't affect each other. But that is not the best solution, though you can use it for now if it works.

The code you posted is not the optimal way to do this in Godot, maybe it works in Unity or for some old version, I don't know. But it will basically have to be completely rewritten, I don't think any of it is optimal, and the code there could be like 4 or 5 lines of code total if done the right way.

I could write it for you, but I think if would be more helpful if you learned. So I would recommend reading all the Step by Step tutorials on this page first: https://docs.godotengine.org/en/stable/getting_started/step_by_step/index.html

This is also the best Godot book, and maybe the best game development book in general, so you should definitely read this as well: https://www.amazon.com/Godot-Engine-Game-Development-Projects-ebook/dp/B079HZD1S7

I think if you read all that, you'll be able to figure it out on your own.

UrielP

Didn't work. But I'm following your advice and I'm going to read all of this. Thank you.

newmodels

You might need to set position after it's added as child. Setting it's position when outside the scene tree should have given you an error. Also, you can try putting print_debug("") into the block making function to see if it's even getting called.

newmodels

Looking at process, I noticed you used the clock ticks from the operating system. You should be using delta in the process function.

UrielP

I already solved it! The problem was, that in my _ready function of the Game, I was connecting the signal just with the $BlockT node, not actually with the instantiated scenes, that's why all the game was working around what happened inside this particular script and apparently all the game stopped when I was calling the set_process(false) function. I just connected the signal with the instantiated scene and all is working fine now. Thanks for your answers!