PoolByteArray.decompress_dynamic() BUG?

PeterPM

So, trying to work with compression and decompression, and i need to use the dynamic so i dont need to know the size of my array.

But, there seens to be a bug.

This is the reproduction code:

The console output

As noted, it is not working, the return of the function does not match the docs, as it its always returning a bolean(true, to all 4 compressions tipes, do not tested on a malformed input to see if it returns false)

So, this seens like a simple bug, in the C++ code, that is returning some confirmation of the sucess of the decompression operation, or whatever, instead of the output of the method.

I am doing something wrong or anyone can reproduce? If yes, is this reported? And if no, what to do, i need to report it on github, never did that.?

Thanks for the help.

Calinou

Please open an issue on GitHub with a minimal reproduction project attached.

PeterPM

I think its done.> @Calinou said:

Please open an issue on GitHub with a minimal reproduction project attached.

Calinou

For reference, here's the issue opened on GitHub: https://github.com/godotengine/godot/issues/57644

PeterPM

And it is onready fixed. Beauty on the fly. Thanks. So it will be released on the 3.5, right?

PeterPM

As a find-out. if you use the simpler method, ".decompress()", and pass a really absurd big buffer size, it does always return the correct decompressed array. I dont see any freezeouts in the ready function, so it must not lag in a any sense when just decompreesing a really smaller array the the buffer.... SO, until the fix is released, using a PoolByteArray.decompress(10000000000,1) is akin to the dynamic one.

Is that a good workarroud?

Megalomaniak

if it works for you then, hey...