untitled FPS: Page 8 - Godot Community Forums

untitled FPS

DJM

im also wondering why the scaling is happening this is the arrow glb file im using https://drive.google.com/file/d/1cRCu-ljyooyjOM0Pv5Gb8YAtr_MwLRyj/view?usp=sharing

cybereality

impact should be added to the world (not the collider) and you should avoid using global_transform.

Megalomaniak

@cybereality said: impact should be added to the world (not the collider) and you should avoid using global_transform.

TBF there is 1 good reason to parent to the node hit, say you want the decal to stick to a moving platform for an example. But the scaling of the decal node could perhaps be fixed through scale normalization.

cybereality

Sure, you can also scale it to the inverse of the parent scale, but this seems like the incorrect method to me.

collider.add_child(impact)
impact.scale = collider.scale.inverse()

DJM

@Megalomaniak said:

@cybereality said: impact should be added to the world (not the collider) and you should avoid using global_transform.

TBF there is 1 good reason to parent to the node hit, say you want the decal to stick to a moving platform for an example. But the scaling of the decal node could perhaps be fixed through scale normalization.

yes i want to put decals on moving objects thats why i use add child.how do i normalize scale?> @cybereality said:

Sure, you can also scale it to the inverse of the parent scale, but this seems like the incorrect method to me.
collider.add_child(impact)
impact.scale = collider.scale.inverse
im getting "invalid get index inverse" error on that line

when i dont use:

impact.global_transform.origin = p

the impact position is wrong

cybereality

Sorry, I copy pasted wrong.

impact.scale = collider.scale.inverse()

You can use the global origin, if you want. It will still work, I just think it's a bad design, but it's not wrong.

DJM

@cybereality said: Sorry, I copy pasted wrong.
impact.scale = collider.scale.inverse()
You can use the global origin, if you want. It will still work, I just think it's a bad design, but it's not wrong.

strange .... same scaling results.but no errors and lookat

impact.look_at(p + n + Vector3(0.001, 0.0, 0.0))

isnt working, shown in screen in post above

why is global origin a bad design? if i use transform.origin or transform.position i dont get the correct placement

cybereality

I think it's a result of nesting the impact. It's not a good idea because you are mixing coordinate spaces. For example, let us say that the impact was a brick or debris that flew off the wall. If you placed it in the world space, everything would work perfect. If you place it as a child of the wall, then it will inherit the wall scaling (as well as any parent scaling). As well as other transformations like rotation. So if the brick moved by 1 meter, but scale was at 2, then the brick would not move at the correct speed (it would be too fast). Or if the brick was supposed to fall, it could be completely off, moving at the wrong speed, maybe gravity would not be down, and it would not be able to interact with the floor or any other objects. It creates weird and hard to understand bugs and it's just not a good idea.

spacecloud

look_at is giving the correct result, it just looks wrong because the arrows face up when they are not rotated.

DJM

@spacecloud said: look_at is giving the correct result, it just looks wrong because the arrows face up when they are not rotated.

ok , decals in godot4 face Yup so the arrow i made is also facing Yup . how do i make it so Yup points at the correct normal?

DJM

@cybereality said: I think it's a result of nesting the impact. It's not a good idea because you are mixing coordinate spaces. For example, let us say that the impact was a brick or debris that flew off the wall. If you placed it in the world space, everything would work perfect. If you place it as a child of the wall, then it will inherit the wall scaling (as well as any parent scaling). As well as other transformations like rotation. So if the brick moved by 1 meter, but scale was at 2, then the brick would not move at the correct speed (it would be too fast). Or if the brick was supposed to fall, it could be completely off, moving at the wrong speed, maybe gravity would not be down, and it would not be able to interact with the floor or any other objects. It creates weird and hard to understand bugs and it's just not a good idea. this indeed gives correct scaling
get_tree().get_root().add_child(impact)
but how do u add decals to moving objects or rigiddynamicbodies then? isnt there a way to make scaling independent of the root?

spacecloud

Putting

impact.basis = impact.basis.rotated(impact.basis.x, PI / 2)

After the look_at call should make them face the right way. (it might be -PI /2 instead)

DJM

@spacecloud said:
impact.basis = impact.basis.rotated(impact.basis.x, PI / 2)
After the look_at call should do it. (it might be -PI /2 instead)

it was -PI/2 , tnx for your answer , i have no idea how that code works and why it is necessary to do an extra rotation after a lookat func but decals point correct now.awesome.

do u have any idea to add child decals to objects with independent scaling?

cybereality

The arrow should be pointing toward -Z in its scene. The inverse() function should handle the scaling. Not sure why the code I posted didn't work. It works for me.

DJM

no, decals in godot4 are Yup.(local space) the scaling code doesnt work in my scene

spacecloud

Maybe

impact.global_transform = impact.global_transform.orthonormalized()

@DJM said:
i have no idea how that code works

you may want to look at Matrix Transforms.

DJM

@spacecloud said: Maybe
impact.global_transform = impact.global_transform.orthonormalized()
@DJM said: i have no idea how that code works you may want to look at Matrix Transforms.

tnx alot! that works perfect in case anybody wants to do the same with raycasting to a textureRect into the world heres' the working script

extends Camera3D
const ray_length = 1000
@export var reticle_path: NodePath
@export var impact_normal : PackedScene
@export var force = 20.0
@export var damage = 50.0
@onready var reticle = get_node(reticle_path)
var random = RandomNumberGenerator.new()
func ready():
	random.randomize()
func firebullet():
	
	var screen_pos = reticle.get_global_transform_with_canvas().origin
	
	var add = reticle.get_texture().get_size().x /2
	var wantedpos = Vector2(screen_pos.x +add, screen_pos.y +add)
	var camera = self
	var from = camera.project_ray_origin(wantedpos)
	var to = from + camera.project_ray_normal(wantedpos) * ray_length
	var space = get_world_3d().direct_space_state
	
	var phys = PhysicsRayQueryParameters3D.new()
	phys.from = from
	phys.to = to
	phys.collision_mask = 1
	var result = space.intersect_ray(phys)

	if result:
		var collider = result.collider
		var n = result.normal
		var p = result.position
				
		var impact = impact_normal.instantiate()
		collider.add_child(impact)
		
		
		impact.global_transform.origin = p 
		impact.look_at(p + n)
		
		impact.basis = impact.basis.rotated(impact.basis.x, -PI / 2)
		impact.global_transform = impact.global_transform.orthonormalized()
		
		
		if collider is RigidDynamicBody3D:
			collider.apply_impulse( p - collider.transform.origin ,  self.global_transform.basis.z * force)

DJM

@spacecloud how to add random scale and rotation to the decal ?

DJM

i fixed the scaling of the decal by setting the 'extends' in the decals' script now i need to figure out random rotation on Yaxis

extends Decal
@export var impactSound : AudioStreamSample
@export var myAudioStream_path: NodePath
@export var maxExtends = 0.1
@export var minExtends = 0.02
@export var particles : PackedScene
@onready var random = RandomNumberGenerator.new()
@onready var myAudio = get_node(myAudioStream_path)

func _ready():
	
	random.randomize()
	add_to_group("ignore")
	var impactparticles = particles.instantiate()
	get_tree().get_root().add_child(impactparticles)
	impactparticles.global_transform.origin = self.global_transform.origin
	impactparticles.emitting = true
	playImpactSound()
	var size = random.randf_range(minExtends,maxExtends)
	self.extents = Vector3(size,size,size)

func playImpactSound():
	if not is_instance_valid(myAudio):
		return
	myAudio.stream = impactSound
	myAudio.pitch_scale = random.randf_range(0.8, 1.2)
	if myAudio.playing  == false:
		myAudio.play()
	else:
		myAudio.queue_free()


func _on_visible_on_screen_notifier_3d_screen_exited():
	self.queue_free()

im also wondering why my particles spawn at the same position even if i enable/disable local coordinates of the drawing of the particle mesh they always spawn at world root axis

edit' particles spawn at hit objects' pivot point not at instantiated decal position

spacecloud

Calling rotate_y with a random angle should do it.

basis = basis.rotated(impact.basis.x,
Is actually the same as rotate_x, i didnt notice that yesterday.

I don't know about the particles.

« Previous Page Next Page »