rotation glitches when reaching 360 degrees: Page 4

rotation glitches when reaching 360 degrees

DJM

@xyz said: camera is the node that does camera orientation. In your case I think it's CamRoot. world_space_delta is a Vector3 that represents the difference (delta) between player's positions on current and previous frame. So instead of storing only x component of previous position like you're doing now, you'll need to store complete Vector3
var player_tanslation_this_frame = self.translation
var world_space_delta = player_translation_this_frame - player_translation_last_frame
var offset3 = $CamRoot.global_transform.basis.xform_inv(world_space_delta).x

player_translation_last_frame = player_tanslation_this_frame
Note that you can use shorter variable names to increase code readability, and skip some surplus assignments. No need to copy my long names. I used them solely to clarify the concept.
var world_delta = self.translation - translation_before 
var offset3 = $CamRoot.global_transform.basis.xform_inv(world_delta).x
translation_before = self.translation

works like a charm. tnx!

xyz

@DJM I hope we'll see this long in the making sway in action in your wip thread ;)

DJM

im trying to port my scripts to godot 4

here is a snippet from my script in godot3

func _process(delta):
	window_activity()
	var softness = 2.0
	
	
	var cam_basis_this_frame = $CamRoot.transform.basis 
	var player_basis_this_frame = self.transform.basis
	var player_tanslation_this_frame = self.translation
	var offset1 = calculate_sway_offset(cam_basis_last_frame, cam_basis_this_frame)
	var offset2 = calculate_sway_offset(player_basis_last_frame, player_basis_this_frame)
	var world_space_delta = player_translation_last_frame - player_tanslation_this_frame
	var offset3 = $CamRoot.global_transform.basis.xform_inv(world_space_delta).x
	
	var offset = Vector3(offset2.x, offset1.y,-offset3) #may need to swap 1 and 2
	do_sway(weaponsway, offset, delta * softness)
	cam_basis_last_frame = cam_basis_this_frame;
	player_basis_last_frame = player_basis_this_frame;
	player_translation_last_frame = player_tanslation_this_frame
	

func calculate_sway_offset(basis_last_frame: Basis, basis_current_frame: Basis):
	var q1 = basis_last_frame.get_rotation_quat()
	var q2 = basis_current_frame.get_rotation_quat()
	var q = q1.inverse() * q2
	var eu = q.get_euler()
	return Vector2(eu.y, eu.x)
 
	
func do_sway(sway_node, offset: Vector3, fract: float):
	var offset_quaternion: Quat = Quat(Vector3.UP, offset.x) * Quat(Vector3.RIGHT, offset.y)* Quat(Vector3.FORWARD,(offset.z *2))
	sway_node.transform.basis = Basis(Quat(sway_node.transform.basis).slerp(offset_quaternion, fract))

this doesnt compile anymore, says it cant find property get rotation quat>

var q1 = basis_last_frame.get_rotation_quat()
var q2 = basis_current_frame.get_rotation_quat()

TwistedTwigleg

I think the get_rotation_quat function was renamed to get_rotation_quaternion in Godot 4.0

DJM

@TwistedTwigleg said: I think the get_rotation_quat function was renamed to get_rotation_quaternion in Godot 4.0 tnx , that worked

these lines also dont compile in godot4

func do_sway(sway_node, offset: Vector3, fract: float):
	var offset_quaternion: Quat = Quat(Vector3.UP, offset.x) * Quat(Vector3.RIGHT, offset.y)* Quat(Vector3.FORWARD,(offset.z *2))
	sway_node.transform.basis = Basis(Quat(sway_node.transform.basis).slerp(offset_quaternion, fract))

velocity_info = move_and_slide_with_snap(velocity, snap, Vector3.UP, true, 4, deg2rad(45))

DJM

linear interpolate also seems to be changed this doesnt compile

self.transform.origin = self.transform.origin.linear_interpolate(runPos, 10 * delta)

TwistedTwigleg

I think Quat is now Quaternion, so you may need to change that. I'm not sure for the move and slide with snap code snippet though.

For the linear interpolate, I think it was renamed to lerp.

DJM

@TwistedTwigleg said: I think Quat is now Quaternion, so you may need to change that. I'm not sure for the move and slide with snap code snippet though.

For the linear interpolate, I think it was renamed to lerp.

that worked "move and slide"code is a problem tho

TwistedTwigleg

For move_and_slide, it looks like it doesn't take any arguments anymore and you have to configure what was the argument as properties of the node. At least, that is what I gather based on the documentation.

DJM

@TwistedTwigleg said: For move_and_slide, it looks like it doesn't take any arguments anymore and you have to configure what was the argument as properties of the node. At least, that is what I gather based on the documentation. fixed it by just getting the "real velocity()length

rotation degrees doesnt seem to be supported anymore

$CamRoot/HeadBob.rotation_degrees.z = yTilt

DJM

"translation" also isnt working anymore

var player_tanslation_this_frame = self.translation

cybereality

It's called position. Reading the documentation might help (press F1 in the editor).

DJM

@cybereality said: It's called position. Reading the documentation might help (press F1 in the editor). tnx that worked

f1 doesnt open documentation in my case.

$CamRoot/HeadBob.rotation_degrees.z = yTilt

what is the new "rotation_degrees" code?

cybereality

You can read the docs online here: https://docs.godotengine.org/en/latest/

DJM

my weapon sway code does compile, but doesnt do anything anymore i cant figure out why

var softness = 2.0
	
	
	var cam_basis_this_frame = $CamRoot.transform.basis 
	var player_basis_this_frame = self.transform.basis
	var player_tanslation_this_frame = self.position
	var offset1 = calculate_sway_offset(cam_basis_last_frame, cam_basis_this_frame)
	var offset2 = calculate_sway_offset(player_basis_last_frame, player_basis_this_frame)
	var world_space_delta = player_translation_last_frame - player_tanslation_this_frame
	
	var offset3 = ($CamRoot.global_transform.basis.inverse() * world_space_delta).x
	
	var offset = Vector3(offset2.x, offset1.y,-offset3) #may need to swap 1 and 2
	#this doesnt work>
	do_sway(weaponsway, offset, delta * softness)
	cam_basis_last_frame = cam_basis_this_frame;
	player_basis_last_frame = player_basis_this_frame;
	player_translation_last_frame = player_tanslation_this_frame
	

func calculate_sway_offset(basis_last_frame: Basis, basis_current_frame: Basis):
	var q1 = basis_last_frame.get_rotation_quaternion()
	var q2 = basis_current_frame.get_rotation_quaternion()
	var q = q1.inverse() * q2
	var eu = q.get_euler()
	return Vector2(eu.y, eu.x)
	
	
func do_sway(sway_node, offset: Vector3, fract: float):
	var offset_quaternion: Quaternion = Quaternion(Vector3.UP, offset.x) * Quaternion(Vector3.RIGHT, offset.y)* Quaternion(Vector3.FORWARD,(offset.z *2))
	sway_node.transform.basis = Basis(Quaternion(sway_node.transform.basis).slerp(offset_quaternion, fract))

DJM

never mind, fixed it delta wasnt multiplied enough

« Previous Page