3rdPerson Player Control and AnimationPlayer

Gowydot

Hi, now I'm learning Player control with AnimationPlayer and I ran into 2 problems

1) The forward && run doesn't play the "run" animation (it got stuck on the 1st frame but will play when I release the button)

2) The Toggle Crouching is buggy (only works once every few pressed)

This is the Code I did. It's just for learning and doesn't have actual movements Thank you


extends KinematicBody

# FOR TOGGLE CROUCHING
var pose = STAND
const STAND = 1
const CROUCH = 0

func _physics_process(delta):

	if Input.is_action_pressed("forward"):
		$AnimationPlayer.play("walk")
	if Input.is_action_pressed("forward") && Input.is_action_pressed("run"):
		$AnimationPlayer.play("run")
....
....
		
# FOR TOGGLE CROUCHING
	if Input.is_action_pressed("crouch"):
		if pose == STAND:
			$AnimationPlayer.play("crouch")
			pose = CROUCH
		elif pose == CROUCH:
			$AnimationPlayer.play_backwards("crouch")
			pose = STAND
			
# BACK TO IDLE LOOP
func _on_AnimationPlayer_animation_finished(anim_name):
	if pose == STAND:
		$AnimationPlayer.play("idle-loop")

fire7side

You have a logic conflict in the walk/run part of your code because both walk and run can be true. If you use an "if" it will run both the code that is true and any other "if" at the same time, so if both buttons are pressed, walk will still be considered to be true and run will be considered to be true. For it to work, I think you would have to check the run first, then use an "elif" for the walk afterward so it runs only one or the other. It might be all right because the animation player will only run one or the other, so, since run is second it changes it to run, but it's not a good idea and I would at least first make it so only one condition can be true at a time.

The problem with your crouch is that you are changing the flag for stand and crouch immediately, instead of when the animation is completed. You need to add code in your animation finished function, where you check the name of the animation. If it was walk or run, you go to idle, if it was crouch, you change the stand or crouch flag. Also, since it's not checking the name of animation, it could be another conflict, depending on how you set it up. The function is giving an animation name when it is called but it's never used.

Gowydot

1) Works. Thank you

	if Input.is_action_pressed("forward") && Input.is_action_pressed("run"):
		$AnimationPlayer.play("run")
	elif Input.is_action_pressed("forward"):
		$AnimationPlayer.play("walk")

2)I've tried setting pose by animation name but I think the problem is I'm using play() and play_backwards() so it produces conflict in setting pose

func _on_AnimationPlayer_animation_finished(anim_name):
	if anim_name == "walk":
		$AnimationPlayer.play("idle-loop")
	elif anim_name == "run":
		$AnimationPlayer.play("idle-loop")
	elif anim_name == "crouch":
		pose = CROUCH

Is there anything I can try to make it work? (without adding movement or more animation)

Gowydot

~~2) *I thought I fixed it but still buggy~~

Actually FIXED IT for real this time =)

# FOR TOGGLE CROUCHING
	if Input.is_action_pressed("crouch"):
		if pose == STAND:
			$AnimationPlayer.play("crouch")
		else:
			$AnimationPlayer.play_backwards("crouch")	


func _on_AnimationPlayer_animation_finished(anim_name):

	if anim_name == "crouch":
		if pose == STAND:
			pose = CROUCH
		else:
			pose = STAND
			$AnimationPlayer.play("idle-loop")

fire7side

Great! Glad you got it working.

Gowydot

Hi, I added movements to my character and now using AnimationTree. Here's the setup:

I got similar problems as before

1) To temporary stop moving while 'attack' animation is being played

2) To toggle Crouching (also temporary stop moving)

I haven't got around to play with StateMachine node yet but wondering if it can be done for now. Thank you

This is what I tried with code:

if is_on_floor():
	# EXAMPLE MOVEMENT CODE
	if Input.is_action_pressed("forward") && Input.is_action_pressed("run"):
		direction.z += 1
		runSpeed = 3
		$AnimationTree.set("parameters/iwr/blend_amount", 1)
	elif Input.is_action_pressed("forward"):
		direction.z += 1
		$AnimationTree.set("parameters/iwr/blend_amount", -1)
	else:
		$AnimationTree.set("parameters/iwr/blend_amount", 0)

	#ONESHOT
	if Input.is_action_just_pressed("attack"):
		$AnimationTree.set("parameters/attackshot/active", true)
		speed = 0

	#TRANSITION
	if Input.is_action_pressed("crouch"):
		if pose == STAND:
			$AnimationTree.set("parameters/standcrouch/current", 1)
			speed = 0
		else:
			$AnimationTree.set("parameters/standcrouch/current", 0)
			$AnimationTree.set("parameters/TimeScale 3/scale", -1)

fire7side

You set your speed to zero when the attack is pressed, so that's what happened, it stopped, same when you set your pose to stand. How that works out with a blend tree, though, I don't know.

Gowydot

Yea, been looking around and seems the only solution is to add a call method track. I will give it a try