I'm new to Godot and nothing in my test project works :(

AlexZfi

Hey Everyone, in the past I've used gamemakerstudio 1 which I got from a humblebundle back then, but since I wanna make more text based games with good GUI support, I've decided I wanna learn Godot. I've learned python to understand GDScript, read a lot in the GDScript Documentation and watched tutorials. I really wanna get into the godot Node-Tree System, but in my TestProject I kinda failed in everyway and don't know what to do.

I hope it's not too much, I got 5 short scripts and a photo of my scene tree.

Also there are two nodes, that appear in their parents tree but not in the complete fern. how can I change that?

So the idea is, the player has ships, these ships are nodes, stored in an array "shiplist", which is a property of the node "shipcollection".

There's another Node "obj_ship_creator" that stores a dictionary with empty basestats for new ships and has a function that creates a new ship from the child node "obj_new_ship", applies a dictionary with basestats to it and returns the node with a new ship when called.

Now there's a Tree of GUI-Nodes, within that Tree there's a scroll container Node "GUI-Shiplist" that is supposed to manage the displaying of the ships in shiplist. The Node "GUI-Shiplist" should also have a function update(), that is supposed to update its content (but doesnt work)

Also in the GUI-Nodes. there's a Button called "Button_AddShip" with a signal to "shipcollection". Upon signal the node should call "obj_ship_creator._create_Ship("default")" and store the returned ship in shiplist. then "GUI-Shiplist"s .update(); function should be called to show the updated fleet.

The Nodes "GUI-Shiplist" and "obj_new_ship" don't appear on the complete root fern, only in their parents trees, idk why

Here's my code: first skript: gui_game_control.gd

extends Control

# Called when the node enters the scene tree for the first time.
func _ready():
	# add_child($"obj_ship_creator");
	add_child($"ship_collection")
	pass # Replace with function body.

second script: GUI-Shiplist.gd

        extends ScrollContainer
        
        # The GUI Scroll Container & Display Manager for Ships
        
        # Called when the node enters the scene tree for the first time.
        func _ready():
        	
        	for n in self.get_children():
        		self.remove_child(n)
        		self.queue_free()
        	
        	for item in get_node("/root/gui_control/ship_collection").shiplist :
        		add_child($Ship_Button);
        		pass;
        	
        
        
        	
        	pass # Replace with function body.
        	
        func update():
        	for n in self.get_children():
        		self.remove_child(n)
        		self.queue_free()
        	
        	for item in get_node("/root/gui_control/ship_collection").shiplist :
        		add_child($Ship_Button);
        		pass;
~~~    

**third script**:  obj_new_ship.gd

extends Node


# This Node is supposed to be duplicated to create new Ships with these functions / (which don't work)


var basestats = {};

var small_overdeck_slots = [];

var small_underdeck_slots = [];



func _sellShip():
	pass
	
func _addToFleet():
	var addPos = get_node("ship_collection").shiplist.size();
	
	get_node("ship_collection").shiplist[addPos] = self;
	
	pass
	
	
# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


**fourth script**:  obj_ship_creator.gd

extends Node


# Declare member variables here. Examples:
# var a = 2
# var b = "text"

# ----- the following dict is used to create new ships base stats ---

var ship_empty_stats = {
	"Name": "none",
	"Size": 0,
	"Small Overdeck Slots" : 0,
	"Small Underdeck Slots" : 0,
	"Medium Overdeck Slots" : 0,
	"Medium Underdeck Slots" : 0,

	# abilities
	"Can Move": false,
	"Can Recover": false,
	"Can Locate": false,
	
	
	"Has Engine" : false,
	"Has Steering" : false,
	"Has Tank" : false,
	"Has Battery" : false,
	
	"Engine Type" : 0,
	"Fuel Efficiency" : 0,
	
	# UHF Location
	"Has UHF Location" : false,
	"Has UHF Loc Creation" : false,  
	"Has UHF Loc Projection" : false,
	"Has UHF Loc Reception" : false,
	
	# recovery
	"Has Lift Net" : false,
	"Lift Net Level" : 0
	
};

# this script is supposed to be called and return a new ship node, that can be saved in an array
func _create_Ship(type):
	
	
	var ship = get_node("obj_new_ship");
	ship.basestats = ship_empty_stats.duplicate();
	
	if (type == "default"):
		
		ship.basestats["Name"] = "Small Crow";
		ship.basestats["Size"] = 1;
		ship.basestats["Small Overdeck Slots"] = 3;
		ship.basestats["Small Underdeck Slots"] = 5;
		
		
		pass
		
	
	#add arrays 
	
	# the following loops are supposed the arrays for equipment ---- don't work
	
	#for i in ship.basestats["Small Overdeck Slots"]-1:
	#	ship.small_overdeck_slots[i] = 0;
		
	
	
	#for i in ship.basestats["Small Underdeck Slots"]-1:
	#	ship.small_underdeck_slots[i] = 0;
		
	
	#add mehtods for ship
	
	
	
	return ship
	pass
	

# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


**fifth script**: ship_collection.gd

extends Node


# Declare member variables here. Examples:
# var a = 2
# var b = "text"


#this array shall store the players fleet from now on 
var shiplist = [];




# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


# Called every frame. 'delta' is the elapsed time since the previous frame.
#func _process(delta):
#	pass




func _on_Button_AddShip_button_up():
	var shipmaker = get_node("/root/gui_control/obj_ship_creator");
	var addShip = shipmaker._create_Ship("default");
	
	#-----  probably doesn't work
	shiplist.push_back(addShip)
	
	# update GUI Shiplist / ---- doesn't work
	var gui_list = get_node("/root/gui_control/PanelContainer/VSplitContainer/HSplitContainer/PanelContainer2/GUI_Shiplist");
	gui_list.update();
	pass # Replace with function body.



Yeah, I kinda know nothing about correct referrencing and making a good node system in godot, also about object creation

TwistedTwigleg

Welcome to the forums @AlexZfi!

Also there are two nodes, that appear in their parents tree but not in the complete fern. how can I change that?

I'm confused, can you elaborate on what the issue is?

Nodes can only have a single parent, so a node will only ever appear under it's parent node in the scene tree. You can have nodes that share the same parent, but you cannot have a child node with two parents.

The Nodes "GUI-Shiplist" and "obj_new_ship" don't appear on the complete root fern, only in their parents trees, idk why

Looking at the code for GUI-Shiplist, it looks like you are deleting the node immediately in the _ready function by calling self.queue_free, which deletes the node. This code is what is causing the issue:

# Called when the node enters the scene tree for the first time.
func _ready():
	for n in self.get_children():
		self.remove_child(n)
		self.queue_free()
		
	for item in get_node("/root/gui_control/ship_collection").shiplist :
		add_child($Ship_Button);

Are you trying to delete any children nodes and then add new Ship_Button nodes? If so, there's a few things you will need to do first. First, you will want to put the node you want to spawn into its own scene so you can instance it through code. This tutorial on the Godot documentation explains how instancing works a bit, so it may be worth taking a look for how to do it. Once you have the scene you want to spawn/create in its own scene file, you then need to reference it in your script using something like const SHIP_BUTTON = preload("res://path_to_ship_scene_here.tscn").

Then you can adjust the code to delete all the children nodes and spawn new ones. Here's an example:

const SHIP_BUTTON = preload("res://path_to_ship_scene.tscn")

func _ready():
	# remove old children
	for child in self.get_children():
		child.queue_free() # tell the child node to free itself
		self.remove_child(n)
		self.queue_free()
	
	# Add new buttons
	for item in get_node("/root/gui_control/ship_collection").shiplist:
		# call a function (defined below) that will spawn a new button
		spawn_new_ship_button()

func spawn_new_ship_button():
	# make a new copy/instance of the ship button scene
	var clone = SHIP_BUTTON.instance()
	# add it as a child of this node
	add_child(clone)
	# optionally, we could call functions or set variables here. For example, we'll set its name
	# to "ship_button_num" where "num" is the child number.
	clone.name = "ship_button_" + str(get_child_count())

For obj_new_ship.gd, I haven't really looked at how it's used just yet, but looking at the code I don't see anything right off per say that would be causing issues. I think the issue is in obj_ship_creator, as it isn't creating a new ship node and is just setting the basestats of the obj_new_ship node already in the scene.

To create a new obj_new_ship you need to do make a scene with just the obj_new_ship so it can be instanced in code, similar to the ship button. Then you can do something like this for the _create_ship function in obj_ship_creator:

const OBJ_NEW_SHIP_SCENE = preload("res://path_to_new_obj_ship.tscn")

func _create_ship(type):
	# create a new clone/instance of the new_obj_ship scene
	var new_ship = OBJ_NEW_SHIP_SCENE.instance()
	# add it as a child of this node
	add_child(new_ship)
	
	# Set the base stats
	if (type == "default"):
		new_ship.basestats["Name"] = "Small Crow"
		new_ship.basestats["Size"] = 1
		new_ship.basestats["Small Overdeck Slots"] = 3
		new_ship.basestats["Small Underdeck Slots"] = 5
	
	return new_ship

I didn't look through every script super closely, but I hope this at least helps give an idea on what could be causing the issue(s) :smile:

AlexZfi

Thanks for your fast and helpful answer <3 When I‘m home I‘ll try to implement your suggestions. Until then I’ll check the documentation again