Why the for loop does not work?

danul77

Why this does not work:

var guns = [$gun1, $gun2]

for i in guns:
	shoot[i] = bullet.instance()
	guns[i].add_child(shoot[i])

and this, too:

for i in guns:
	var bullet = []
	bullet.append([])
	bullet[i] = BULLET.instance()
	guns[i].add_child(bullet[i])

???

DaveTheCoder

for i in guns:
    shoot[i] = bullet.instance()
    guns[i].add_child(shoot[i])

Is equivalent to:

shoot[$gun1] = bullet.instance()
guns[$gun1].add_child(shoot[$gun1])
shoot[$gun2] = bullet.instance()
guns[$gun2].add_child(shoot[$gun2])

That's probably not what you want.

I'd have to see more of your project to understand what you're trying to do.

cybereality

You probably want this:

for i in range(guns.size()):

Which will result in i being 0 and 1. But the rest of the code looks suspect as well.

danul77

Then I get this message: "Invalid set index '0' (on base: 'Array') with value of type 'KinematicBody (scriptname.gd)'

DaveTheCoder

What line of code produces that error message?

cybereality

That might mean the Array is empty and if you access it by index you are trying to access and assign a value to something that doesn't exist. You might want to try some tutorials first, it sounds like you need to learn the basics before trying whatever it is you are doing.

danul77

shoot.velocity = shoot.transform.basis.z * -800 #error Invalid set index 'velocity' (onbase: 'KinematicBody') with value of type 'Vector3' //My kinematic body was on a offset to the mesh?

#Edit 1: This part works fine:

for i in GUNS:
			var shoot = Bullet.instance()
			mainNode.add_child(shoot)
			shoot.transform = i.global_transform

only the mesh/player kinematicbody moves and away

DaveTheCoder

That error message means that KinematicBody doesn't have a velocity property. https://docs.godotengine.org/en/stable/classes/class_kinematicbody.html#properties And none of KinematicBody's ancestor classes (PhysicsBody, CollisionObject, Spatial, Node, Object) have the property.

You could add the property in the script attached to Bullet. I don't know if that's the correct solution, since only some of your code is posted here.

danul77

Everything I did was based on this tutorial:

nothing else I did.

The trouble with error message I solved by make a script for the bullet itself. So that it works now. Otherwise, there is another trouble: when I shoot my Player moves away to the camera but bullets work fine.

DaveTheCoder

That narrator has me hooked, so I may just do that tutorial.

You can make your own models if you like, but I think my models are better than yours, so just use mine.

:grin:

DaveTheCoder

I did the tutorial except for the last part (Bonus Part / Polishing Time). I got it working, but it was tricky keeping up. Some steps are covered very quickly.

However, the finished project is on github.

danul77

Yes.

danul77

I solved my trouble: Collions shapes interact that why the player change its position