Setting a Camera nodes boundary limits to be the same as a CollisionShape2D's size

SpicoTheMirrorSpirit

Im trying to make a camera motion that sets its boundary size to an amount i specify

I am using an Area2D and its in a "Camera" group, when the game checks if the Area is in that group i want it to grab the global position of that Area2D nodes CollisionShape 2Ds both size, and global coordinates, and set the cameras bounding box to it via funny maths, heres that exact thing, but in code

func _on_Area2D_area_entered(area):
	if area.is_in_group("Camera"):
		# Get colliding Area2D's CollisionShape2D's global position, and size
		# Set the cameras boundary box to the variables the top line of code returns, via $Camera.limit_top = "CollisionShape2Ds global position", $Camera.limit_bottom = "CollisionShape2Ds global position" + "CollisionShape2Ds height" (so i get the other side of it) etc.

How can i get the colliding Area2Ds CollisionShape2D coordinates inside the code?

taiyo-pixels

https://github.com/Harrison-Miller/RoomBasedCamera/blob/master/Player.gd I think this is what you need?

SpicoTheMirrorSpirit

@"Taiyo Pixels" said: https://github.com/Harrison-Miller/RoomBasedCamera/blob/master/Player.gd I think this is what you need?

That is something i tried actually, but for some reason no matter what i did it has not worked, but yes thats the thing i want to achieve only with smoothness enabled

SpicoTheMirrorSpirit

@SpicoTheMirrorSpirit said:

@"Taiyo Pixels" said: https://github.com/Harrison-Miller/RoomBasedCamera/blob/master/Player.gd I think this is what you need?

That is something i tried actually, but for some reason no matter what i did it has not worked, but yes thats the thing i want to achieve only with smoothness enabled

After a bit of brainstorming and tempering with that code again, i managed to get it to work! However, though, the camera just snaps into place rather than smoothly transitioning there like how i expected it to do, how can i achieve that?

taiyo-pixels

I am also kinda trying to look for something akin to what you're looking for which is setting an area and having Camera Limits then smoothly transitioning. I suggest using Tweens? Seeing as that's how I got a Legend of Zelda style screen scroll. Let me know if that works

SpicoTheMirrorSpirit

@"Taiyo Pixels" said: I am also kinda trying to look for something akin to what you're looking for which is setting an area and having Camera Limits then smoothly transitioning. I suggest using Tweens? Seeing as that's how I got a Legend of Zelda style screen scroll. Let me know if that works

I tried it, but i cant seem to get it right anyhow, the limit right and bottom always go thrown out the chart while the top and left limits are... the camera im ontop of? anyway heres what i have code vise just know it doesnt work (i replaced the code that changed the cam limits for the record, the last 4 lines of code has been replaced with this) (it doesnt calculate the variables right so i overshoot by alot despite copying it from the code before):

	tween.interpolate_property(cam, "limit_top", cam.limit_top, collision_shape.global_position.y - size.y/2, 1, 2, 0)
	tween.interpolate_property(cam, "limit_left", cam.limit_left, collision_shape.global_position.x - size.x/2, 1, 2, 0)
	tween.interpolate_property(cam, "limit_bottom", cam.limit_bottom, cam.limit_top + size.y, 1, 2, 0)
	tween.interpolate_property(cam, "limit_right", cam.limit_right, cam.limit_left + size.x, 1, 2, 0)
	tween.start()

taiyo-pixels

What about this? It's a Camera2D made by fornclake

taiyo-pixels

I've also found this code from reddit

        foreach (Node node in GetChildren())
        {
            if (node.IsInGroup("level"))
            {
                Room = (Level)node;

                float x = Player.Position.x;
                float y = Player.Position.y;
                float xMin = ((Level)node).LevelPosition.x;
                float yMin = ((Level)node).LevelPosition.y;
                float xMax = ((Level)node).LevelPosition.x + ((Level)node).LevelSize.x;
                float yMax = ((Level)node).LevelPosition.y + ((Level)node).LevelSize.y;

                // If the Player is inside the level.
                if ((x > xMin) && (y > yMin) && (x < xMax) && (y < yMax) && CurrentRoom != node)
                {
                    CurrentLevel = node;
                }
            }
        }

SpicoTheMirrorSpirit

@"Taiyo Pixels" said: What about this? It's a Camera2D made by fornclake

I have been looking at this for the past hour and im unsure if i can integrate it to my code, all i have to do is change the limits while tweening them out, which is what i tried beforehand, the screen camera as is, is the following:

func _on_RoomDetector_area_entered(area):
	var collision_shape = area.get_node("CollisionShape2D")
	var size = collision_shape.shape.extents*2
	var view_size = get_viewport_rect().size
	if size.y < view_size.y:
		size.y = view_size.y
		
	if size.x < view_size.x:
		size.x = view_size.x
	
	var cam = $Camera2D
	var tween = $Camera2D/Tween
	
#     this is the old camera code that only sets the value
#	cam.limit_top = collision_shape.global_position.y - size.y/2
#	cam.limit_left = collision_shape.global_position.x - size.x/2
	
#	cam.limit_bottom = cam.limit_top + size.y
#	cam.limit_right = cam.limit_left + size.x
	
#     This is the new one that doesnt function well
	tween.interpolate_property(cam, "limit_top", cam.limit_top, collision_shape.global_position.y - size.y/2, 1, Tween.TRANS_LINEAR, Tween.EASE_IN_OUT)
	tween.interpolate_property(cam, "limit_left", cam.limit_left, collision_shape.global_position.x - size.x/2, 1, Tween.TRANS_LINEAR, Tween.EASE_IN_OUT)
	tween.interpolate_property(cam, "limit_bottom", cam.limit_bottom, cam.limit_top + size.y, 1, Tween.TRANS_LINEAR, Tween.EASE_IN_OUT)
	tween.interpolate_property(cam, "limit_right", cam.limit_right, cam.limit_left + size.x, 1, Tween.TRANS_LINEAR, Tween.EASE_IN_OUT)
	tween.start()

UPDATE: It seems that the top and the left side limits work just fine, the problem is the bottom and the right side limits, the bottom limit is very inconsistent, while enabling right always breaks it in a way, also, enabling the code makes the camera have a stroke for a few seconds but then it readjusts itself after 1-2 seconds

taiyo-pixels

Perhaps keep the original limit code and replace size.x = view_size.x with the tween starting?

taiyo-pixels

I also found this while searching https://godotmarketplace.com/shop/2d-camera-limiter/

SpicoTheMirrorSpirit

@"Taiyo Pixels" said: Perhaps keep the original limit code and replace size.x = view_size.x with the tween starting?

I have tried that im very unsure what that would do but it has not changed much ;^;

@"Taiyo Pixels" said: I also found this while searching https://godotmarketplace.com/shop/2d-camera-limiter/ this was... suprisingly helpful but not really what i was trying to do, he got those coordinates by position2ds instead of calculating it himself, which is what i want to happen so level creation can be easier, really appericiate it though showed me a different way of doing it!

taiyo-pixels

Another update though this may not be a Camera2D this seems like a good fit

SpicoTheMirrorSpirit

@"Taiyo Pixels" said: Another update though this may not be a Camera2D this seems like a good fit

Thats not really what im trying to do though i already know that much ;^; im just trying to get the boundaries to slide to a different location so it looks good

taiyo-pixels

https://github.com/nezvers/Godot_Public_Examples/blob/master/Zelda_camera_transition/src/Objects/Camera.gd It may not be 100% what you're looking for but you could probably program the limits around it

evpevdev

Maybe I'm missing the question, but what about setting cam.smoothing_enabled = true and cam.limit_smoothed = true, then set the limits directly without tweening.

Also, do you want the camera to zoom in and out to fit the area exactly or just have the area only limit the camera's position?