Enemy does not die

adcoding

Enemy is hit by bullets (I used a RigidBody node because they bounce off the enemy and with scene elements). The collision occurs, but the enemy does not lose life and therefore does not die.

Bullet.gd

extends RigidBody

var speed : float = 500.0
var damage: int = 1

# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


func _on_Bullet_body_entered(body):
	if body.has_method('take_damage'):
		body.take_damage(damage)
		destroy()

func destroy():
	queue_free()

Enemy.gd

extends KinematicBody

#stats
var health : int = 5
var moveSpeed : float = 1.0

#attacking
var damage : int = 1
var attackRate : float = 1.0
var attackDist : float = 2.0

var scoreToGive : int = 10

#components
onready var player : Node = get_node("/root/MainScene/Player")
onready var timer : Timer = get_node("Timer")

# Called when the node enters the scene tree for the first time.
func _ready():
	#setup the timer
	timer.set_wait_time(attackRate)
	timer.start()
	$ChickenSound.play()

func _physics_process(_delta):
	#calculate direction to the player
	var dir = (player.translation - translation).normalized()
	dir.y = 0
	#move the enemy towards the player
	
	dir = move_and_slide(dir * moveSpeed, Vector3.UP)
	look_at(player.global_transform.origin, Vector3.UP)

	

func take_damage ():
	health -= damage
	#if have ran out of health - die
	if health <= 0:
		die()

func die ():
	player.add_score(scoreToGive)
	queue_free()
	
#deals demage to the player
func attack ():
	player.take_damage(damage)


func _on_Timer_timeout():
	#if we are at the right distance, attack the player
	if translation.distance_to(player.translation) <= attackDist:
		attack()

adcoding

In the player.gdthere also a take_damage function

func take_damage (damage):
	curHp -= damage
	ui.update_health_bar(curHp, maxHp)
	if curHp <= 0:
		die()

Megalomaniak

Notice how your player function take_damage (damage): has a input variable damage but the enemy script take_damage (): doesn't.

adcoding

I tried to set that variable into take_damage () of the enemy script. So take_damage (damage) But it doesn't work. and returns an error (SHADOWED_VARIABLE): The local variable 'damage' is shadowing an already-defined variable at line 8.

This is the enemy Scene:

Megalomaniak

try formatting the take damage functions(both of them) like this:

func take_damage(dmg):
    curHp -= dmg
    # rest of function

adcoding

It's not working :(

Here also the bullet Scene screen:

Erich_L

You mentioned the bullets both bounce off enemies and also that your problem is that the bullets don't "enter" them. I don't think you can have it both enter a body AND bounce off of it. Are you sure this function is being called? func _on_Bullet_body_entered(body):

Megalomaniak

Ah yes, nice catch. I completely overlooked that thinking there was collision handling as well.

adcoding

Yes the function is not called.

    func _on_Bullet_body_entered(body):
    	if body.has_method('take_damage'):
    		body.take_damage(damage)
    		destroy()
    		print("test")

So?

Megalomaniak

Instead of relying on body_entered you'll have to monitor contacts.

https://docs.godotengine.org/en/stable/classes/class_rigidbody.html#class-rigidbody-property-contact-monitor

or alternatively consider

https://docs.godotengine.org/en/stable/classes/class_rigidbody.html#class-rigidbody-property-continuous-cd

adcoding

Thanks so much, I try it and let you know

adcoding

Maybe I'm doing something wrong:

        func set_contact_monitor(body):
        	if body.has_method('take_damage'):
        		body.take_damage(damage)
        		destroy()
        		print("test")

Megalomaniak

I'm sorry, I should have been clearer, instead of relying on body_entered alone you have to also enable contact monitoring.

https://docs.godotengine.org/en/stable/tutorials/physics/physics_introduction.html#contact-reporting https://docs.godotengine.org/en/stable/classes/class_rigidbody.html#signals

func _ready():
    set_contact_monitor(true)
    set_max_contacts_reported(2) # more is better but more costly

func _on_Bullet_body_entered(body):
    if body.has_method('take_damage'):
        body.take_damage(damage)
        destroy()

adcoding

I changed some var/func name so It's more clear to understand cause my brain was burning lol bullet.gd

var damageBullet: int = 1

func _ready():
	set_contact_monitor(true)
	set_max_contacts_reported(2) # more is better but more costly

func _on_Bullet_body_entered(body):
	if body.has_method('take_damageToEnemy'):
		body.take_damageToEnemy(damageBullet)
		destroy()
		
func destroy():
	queue_free()

I'm not sure that 'body' is the enemy....

In the Enemy.gd

func take_damageToEnemy (damageBullet):
	health -= damageBullet
	if health <= 0:
		die()

I can't figure out why this function is not called

Screen to show that bullets hit the enemy and bounce away

Erich_L

I haven't worked with this stuff much before, but my best guess is that you should use a different function. If no body is actually "entering" the body, I don't see any reason for that function to be called. My best guess is to try this function which I see in the kinematic body documentation: KinematicCollision move_and_collide(rel_vec: Vector3, infinite_inertia: bool = true, exclude_raycast_shapes: bool = true, test_only: bool = false)

Moves the body along the vector rel_vec. The body will stop if it collides. Returns a KinematicCollision, which contains information about the collision.

If test_only is true, the body does not move but the would-be collision information is given.

Megalomaniak

write a print statement to see what body is being collided with:

var damageBullet: int = 1

func _ready():
    set_contact_monitor(true)
    set_max_contacts_reported(2) # more is better but more costly

func _on_Bullet_body_entered(body):
    print(body)
    if body.has_method('take_damageToEnemy'):
        body.take_damageToEnemy(damageBullet)
        destroy()

func destroy():
    queue_free()

If it is as I expect it'll be the collision shape that is the child of your kinematic body. So you'll have to use body.get_parent() first so something like

var damageBullet: int = 1

func _ready():
    set_contact_monitor(true)
    set_max_contacts_reported(2) # more is better but more costly

func _on_Bullet_body_entered(body):
    print(body)
    var owner = body.get_parent()
    if owner.has_method('take_damageToEnemy'):
        owner.take_damageToEnemy(damageBullet)
        destroy()

func destroy():
    queue_free()

adcoding

@Megalomaniak The output of the print statement sends me two IDs: StaticBody:1257 when I shoot the bullets (1257 is the Floor) StaticBody:1306 when bullet touch the enemy (1306 is the StaticBody of the Enemy)

Megalomaniak

And the StaticBody is child of the enemy node?

adcoding

@Megalomaniak I solved!!! It was the StaticBody in the enemy structure!!!

I'm so happy cause I was stuck for 2 weeks lol

Thank you so much!!!