I need advice on how to make a decent weapon switching system in Godot, any advice?: Page 2

I need advice on how to make a decent weapon switching system in Godot, any advice?

Audiobellum

@cybereality said: Not sure about that. I haven't really used many tutorials, I've mostly just been reading the documentation and testing features out myself.

Cool. I originally avoided reading the documentation on the official website as I've only had constant access to the internet recently relatively recently and I didn't know where to find a PDF version of it, so that I can download. I'll check it out.

Audiobellum

@cybereality said: Not sure about that. I haven't really used many tutorials, I've mostly just been reading the documentation and testing features out myself.

Do you know where I can download a pdf of Godot's documentation?

Calinou

Do you know where I can download a pdf of Godot's documentation?

PDF downloads are no longer offered because the PDF generated by Sphinx was almost unreadable. Instead, you can use the HTML downloads provided here: https://docs.godotengine.org/en/stable/ (see the section about HTML at the top)

Audiobellum

@Calinou said:

Do you know where I can download a pdf of Godot's documentation?

PDF downloads are no longer offered because the PDF generated by Sphinx was almost unreadable. Instead, you can use the HTML downloads provided here: https://docs.godotengine.org/en/stable/ (see the section about HTML at the top)

Thanks

cybereality

Okay, I downloaded the project and made a bunch of changes. Hopefully you can look through and it will help you understand what I did. https://drive.google.com/file/d/1V6kZ-OjR4GaqWlRqX01LCnVFUEE982zW/view?usp=sharing

Audiobellum

@cybereality said: Okay, I downloaded the project and made a bunch of changes. Hopefully you can look through and it will help you understand what I did. https://drive.google.com/file/d/1V6kZ-OjR4GaqWlRqX01LCnVFUEE982zW/view?usp=sharing

Thanks. I'm starting to understand how the changes work the more I make comparisons between what I have and the changes you made. I think I understand what you've down to the Weapon.pd in it's entirety. I never knew that wheel up and wheel down could have been established as inputs, cool. It seems that the more I think about the code, is the more I understand what's going.

The code underfunc setup_weapons(): gets the variable for each weapon in the Weapon.pd script and then set it's string equal to it's respective equip animation. I think I understand the code underfunc switch_weapon(): but, I don't understand what the != does in if current_weapon != weapons[weapon_index]: . Judging by the context, I think it means not or =/= in Godot.

When it comes to func switch weapon(): it seems that all the code under if current_weapon != weapons[weapon_index]: executes itself in a sequential matter, (one after the other) as oppose to all at the same time.

When it comes to the code for switching weapons with mouse wheel, I don't understand what weapon_index = (weapon_index + 1) % weapons.size() works, more specifically it's the % weapons.size() I don't understand. Anyway, I'm going to do my best to understand these changes and then let them inform how I do coding in GDscript in the future.

DaveTheCoder

weapon_index = (weapon_index + 1) % weapons.size()

That's a common way of cycling through a list. The modulus operator (%) means "remainder upon division by".

Erich_L

give me enough time I'll think of a way to use AStar to do it B) lolol

Audiobellum

@DaveTheCoder said:

weapon_index = (weapon_index + 1) % weapons.size()

That's a common way of cycling through a list. The modulus operator (%) means "remainder upon division by".

I just discovered that I don't know what the "size" in weapons.size() means. Could you explain that to me?

DaveTheCoder

It's the number of elements in the weapons array (assuming it's an array). https://docs.godotengine.org/en/stable/classes/class_array.html#class-array-method-size

Audiobellum

Okay, so where I'm at now is that I've managed to successfully implement the "wheel up" and "wheel down" Inputs into the mouse wheel code I originally had; replying the unnecessary stuff I previously had and the code looks neater for it.

	if Input.is_action_just_pressed("wheel_up"):
		if current_weapon < 3:
			current_weapon += 1
		else:
			current_weapon = 1
	if Input.is_action_just_pressed("wheel_down"):
		if current_weapon > 1:
			current_weapon -= 1
		else:
			current_weapon = 3

As you can see, I haven't got around to using the arrays yet. Will be right back when I have success with that.

Audiobellum

@DaveTheCoder said: It's the number of elements in the weapons array (assuming it's an array). https://docs.godotengine.org/en/stable/classes/class_array.html#class-array-method-size

I just found out about what it does elsewhere in a Youtube tutorial. Thanks.

Audiobellum

@DaveTheCoder

Okay, so here is my idea for switching weapons with my scroll wheel. Since arrays have to start at zero and I don't want to make any more changes to my scroll wheel code (yet). I've made my array look like this:

var none = 1

var weapons = [none,pistol, shotgun, rifle]

To switch weapons through my array, I'll use a code like this:

weapons[current_weapon]

However, I'm still having problems finding a simple way to use this code to replace my wall of elif statements:

	if current_weapon == 1:
		pistol.visible = true
		pistol.shoot()
	else:
		pistol.visible = false

	if current_weapon == 2:
		shotgun.visible = true
		shotgun.shoot()
	else:
		shotgun.visible = false

	if current_weapon == 3:
		rifle.visible = true
		rifle.shoot()
	else:
		rifle.visible = false

My plan was to do something like this:

weapons[current_weapon].visible.true pistol.shoot()

However, I'm still running into problems. Any advice?

Audiobellum

Thanks for the help everyone. I think I'm just going to go and learn how to code in general before returning back to this subject, wish me the best of luck. I will not quit.

cybereality

For Godot, I thought this book was really good. https://www.amazon.com/Godot-Engine-Game-Development-Projects-ebook/dp/B079HZD1S7/

And for general programming, this one is good (it is C++ but the ideas apply everywhere). https://www.amazon.com/Beginning-Through-Game-Programming-Fourth-ebook/dp/B00LZW07P0/

Audiobellum

@cybereality said: For Godot, I thought this book was really good. https://www.amazon.com/Godot-Engine-Game-Development-Projects-ebook/dp/B079HZD1S7/

And for general programming, this one is good (it is C++ but the ideas apply everywhere). https://www.amazon.com/Beginning-Through-Game-Programming-Fourth-ebook/dp/B00LZW07P0/

Thanks.

OpinionatedGamer

@Audiobellum said: Thanks for the help everyone. I think I'm just going to go and learn how to code in general before returning back to this subject, wish me the best of luck. I will not quit.

Good, never quit! You seem to be coding already, so that's a great head start, lol. If it makes you feel better, I've messed around with coding for several years and I still have trouble whenever it comes to arrays, although I'm getting much more comfortable now. =) It must be that you never mess with arrays much until you start a real project.

Audiobellum

@OpinionatedGamer @cybereality @DaveTheCoder Okay, so I've found some sort of solution to my problems. Basically, functions can be attached to any input in GDscript, so I made a function that would manage all my equip animations. In order to avoid using an array, I just used the match to match my current_weapon number with the required animation in the function responsible for switching weapons. After that, I just integrated that function into my code for switching weapons with the mouse wheel and the results are decent. Of course, I haven't found away to implement the unequip animations into the code probably. I know how to use yeild($anim_player. "animation_finished") but, even though it technically worked for making the transition between equip and unequip animations possible, there was always this awkward pause at the beginning of the unequip animations where I'd see what appears to be the final frame of the animation at the beginning of the animation for a single frame. Needless to say, I'm satisfied with just having the equip animations working when switching weapons with the mouse wheel. Of course my code could be more optimized but, as a beginner trying to make a demo, code optimization isn't my top priority (though I am looking into mentions by which I can get it done still).
As I've alluded to, I'm still having problems using arrays. I do know how to store integers, floats and strings into an array. However, I do have a problem with storing other established variables into an array. However, all of that is an issue for another day in another threat and perhaps I can find the solution to that problem somewhere else.

DaveTheCoder

It gets more fun when you start combining arrays and other things. The config file I've set up for saving my game is a Dictionary. One of the dictionary elements is an array of dictionaries. Two of the elements of those dictionaries are also dictionaries. :)

Audiobellum

@DaveTheCoder said: It gets more fun when you start combining arrays and other things. The config file I've set up for saving my game is a Dictionary. One of the dictionary elements is an array of dictionaries. Two of the elements of those dictionaries are also dictionaries. :)

What about putting referred nodes into an array? Let's say that I have a bunch of variables similar to this: var thing = $thing. Whenever I put variables like this in array, I don't get any arrays until I try to use the array back trying to get the index of what's in it. What works for me is if I re-establish the array inside of a function by just copying and pasting to code for the array into the function, while removing the part that says var at the end. However, that has it's obvious limitations.

« Previous Page Next Page »