Formating or just renovation of a movement code

IgoCigo

extends KinematicBody2D

var velocity = Vector2(0,0)
var coins = 0
const SPEED = 350
const JUMPFORCE = -1100
const GRAVITY = 35
const FRICTION = 1

func _physics_process(delta):
    
    if Input.is_action_pressed("ui_right"):
        velocity.x = SPEED
    elif Input.is_action_pressed("ui_left"):
        velocity.x = -SPEED
    else:
        velocity = velocity.move_toward(Vector2.ZERO, FRICTION * delta)

    velocity.y = velocity.y + GRAVITY

if Input.is_action_just_pressed("ui_up") and is_on_floor():
    velocity.y = JUMPFORCE

velocity = move_and_slide(velocity,Vector2.UP)

velocity.x = lerp(velocity.x,0,0.2)

Alright so I am very new to programming and I was wondering why this code won't work, can you please help me?

TwistedTwigleg

Welcome to the forums @IgoCigo!

How is the code not working? Is the player not moving correctly, Godot giving an error, or something else?

Based on the code above, the problem is likely indentation, as lines 21 to 26 are not indented by a single tab and therefore will not be interpreted as part of the _physics_process function. To fix this, you just need to give them a single indent:

extends KinematicBody2D

var velocity = Vector2(0,0)
var coins = 0
const SPEED = 350
const JUMPFORCE = -1100
const GRAVITY = 35
const FRICTION = 1

func _physics_process(delta):
	
	if Input.is_action_pressed("ui_right"):
		velocity.x = SPEED
	elif Input.is_action_pressed("ui_left"):
		velocity.x = -SPEED
	else:
		velocity = velocity.move_toward(Vector2.ZERO, FRICTION * delta)
	
	velocity.y = velocity.y + GRAVITY
    	
	if Input.is_action_just_pressed("ui_up") and is_on_floor():
		velocity.y = JUMPFORCE
	
	velocity = move_and_slide(velocity,Vector2.UP)
	
	velocity.x = lerp(velocity.x,0,0.2)

IgoCigo

Let me see if that was the mistake

IgoCigo

I think it worked thanks! Do you know how to add acceleration to this code too?

TwistedTwigleg

Awesome, glad it worked!

For acceleration it really depends on how you want to do it. One way to do it is similar to how you are decelerating on line 17 instead of directly setting the velocity like on lines 13 and 15. Something like this:

# other code here...
const ACCEL = 120;
const MAX_SPEED = 350;

func _physics_process(delta):

	if Input.is_action_pressed("ui_right"):
		velocity.x += ACCEL * delta
		if (velocity.x > MAX_SPEED):
			velocity.x = MAX_SPEED
	elif Input.is_action_pressed("ui_left"):
		velocity.x -= ACCEL * delta
		if (velocity.x < -MAX_SPEED):
			velocity.x = -MAX_SPEED
	else:
		velocity = velocity.move_toward(Vector2.ZERO, FRICTION * delta)
	
	# other code here...

I have not tested the code, but I think it should work.