normals seems to aways face up!

newmodels

I have the a piece of shader code.

vec3 getnorm(vec3 pos,float time){
	
	vec3 newpos3=pos;
	vec3 newpos1=pos;
	vec3 newpos2=pos;

	newpos2.z+= -0.01;
	newpos2.x+= 0.01;

	newpos3.z+= 0.01;
	newpos3.x+= 0.01;
	float h1=swell2(newpos1,time);
	float h2=swell2(newpos2,time);
	float h3=swell2(newpos3,time);
	newpos1.y=h1;
	newpos2.y=h2;
	newpos3.y=h3;
	
	vec3 u=newpos2-newpos1;
	vec3 v=newpos3-newpos1;
	vec3 nor;
	nor.x=(u.y*u.z) - (u.z*u.y);
	nor.y=(u.z*u.x) - (u.x-u.z);
	nor.z=(u.x*u.y) - (u.y*u.x);
	return -nor;
}

Problem I get, is all normals face one direction. And they seem to face up.

TwistedTwigleg

How are you calling the code? Also, have you tried using NORMAL directly to get the normal vector for a vertex?

newmodels

I will double check it. But yes, I assign NORMAL=getnorm(VERTEX,TIME); like this.

newmodels

I am calling the function inside, void vertex(){}

newmodels

vec3 getnorm(vec3 pos,float time){

vec3 newpos3=pos;
vec3 newpos1=pos;
vec3 newpos2=pos;
newpos1.z+= -0.02;
newpos2.x+= -0.02;
newpos3.x+= 0.02;
float h1=swell2(newpos1,time);
float h2=swell2(newpos2,time);
float h3=swell2(newpos3,time);
newpos1.y=h1;
newpos2.y=h2;
newpos3.y=h3;

vec3 u=newpos2-newpos1;
vec3 v=newpos3-newpos1;
vec3 nor;
nor.x=(u.y*v.z) - (u.z*v.y);
nor.y=(u.z*v.x) - (u.x*v.z);
nor.z=(u.x*v.y) - (u.y*v.x);
//nor= normalize(nor);
return nor;

}

I found some typographs in it. But it will not work. Now the water plane is all dark.

newmodels

What about this one. Rather than the last method, what about this one. Take the cross product and get the normal.

vec3 getnorm2(vec3 pos,float time){ vec3 ret;

vec3 newpos3=pos;
vec3 newpos1=pos;
vec3 newpos2=pos;
newpos1.z+= -0.05;
newpos2.x+= -0.05;
newpos3.x+= 0.05;
float h1=swell2(newpos1,time);
float h2=swell2(newpos2,time);
float h3=swell2(newpos3,time);
newpos1.y=h1;
newpos2.y=h2;
newpos3.y=h3;
vec3 u=newpos3-newpos1;
vec3 v=newpos2-newpos1;

ret=u*v;
ret=normalize(ret);

return ret;

}

It for some reason is not working.

newmodels

I have new code. Having erased the project and starting over.

vec3 thenormal2(vec3 vert){ vec3 ret; vec3 p0=vert; vec3 p1=vert; vec3 p2=vert; p1.z+=0.01; p1.x-=0.01; p2.x+=0.01; p2.z+=0.01; p0.y=heightMaker(p0.z); p1.y=heightMaker(p1.z); p2.y=heightMaker(p2.z);

vec3 u=p1-p0;
vec3 v=p2-p0;

ret.x = (u.y*v.z) - (u.z*v.y);
ret.y = (u.z*v.x) - (u.x*v.z);
ret.z = (u.x*v.y) - (u.y*v.x);


return ret;

}

What is happening is the model only gets light from one side. The other side is dark when the light is facing it. The side that has light is getting light as expected.

newmodels

I can also invert the p1 and p2 and get light on the other side. I don't know what's wrong with it. The cross product method gives same results.

newmodels

I think it was a bug in godot 3.2.3. Something is wrong with the directional light. It's working in 3.3.2. But I have to do better tests to prove it. I'm not, I am just going to go on to 3.3.2 and work.

TwistedTwigleg

@newmodels said: I think it was a bug in godot 3.2.3. Something is wrong with the directional light. It's working in 3.3.2. But I have to do better tests to prove it. I'm not, I am just going to go on to 3.3.2 and work.

Sorry about the delay in replying!

Well, good to know that it may be something unrelated to the shader but is instead something on the Godot side. I'll be honest, I don't really understand enough about shaders to fully get what is going on in the shader, but I'm glad you have been able to get closer to finding a working solution :smile:

newmodels

I believe gdquest might have some good tutorials on godot shaders. I plan on purchasing their godot shader secrets so I can learn how to do some better things with it.

I had ended up erasing the water shader, and starting out with a new one. Just a plan noise texture map. The one in the godot manual. It's a little bit different though, not exzact.