a function works, but the animation sprite in it is not played. The code jumps ....

tellheim

Hi there I am glad to be here. I am new to Godot and normally I come from the theater and I am doin 3D stuff. But now I tried out this game engine, and I love it. But I have a problem since two days, as written above. Although a function is workin, and the debugger has no warnings or so, the engine "jumps" one code - line. The code is this one:

func toedlich():
	if is_alive == true:
		$AnimatedSprite.play("Dumm_gelaufen")
		yield($AnimatedSprite, "animation_finished")
		is_alive = false
		queue_free()

everything is executed, except the line with the AnimatedSprite. It even holds the yield for the time, the animation would need. But it does not play it.... I am absolutely confused. If there are any ideas, thank you very very much... tellheim (Sorry for the English, its not my mother language...)

TwistedTwigleg

Welcome to the forums @tellheim!

How are you calling this function? It could be that its being called more than once, and so the AnimatedSprite is told to play the animation over and over again, leading to it never getting past the first frame. I think you can work around this issue by setting is_alive to false before yielding, as then the condition checking to make sure is_alive is equal to true will stop the AnimatedSprite from being told to play the animation more than once.

tellheim

Thanks for that kindly answer. The function is called via the signal of an Area2D:

func _on_Hit_Box_Bomb_area_entered(area: Area2D) -> void: is_alive = true toedlich()

The thing I tried to do, is to give my hero (Flint) an Area2D, that detects all the enemies-Areas2D that are killing him (tödlich). so I need just one Area for different harmful enemies, if the layers and masks are properly used. other enemies, that are harmless, are detected by another Area2D and another signal.

I tried that. Indeed, there was a difference. It at least tried to play the sequence of another animation, that is in a function right similar:

func harmlos(): if is_alive == false: spriteFlint.play("Flint_Faellt") yield(spriteFlint, "animation_finished") is_alive = true

this function is called via signal:

func _on_HarmlosArea2D_body_entered(body: Node) -> void: is_alive = false harmlos()

it can't be that tricky, can it? :-) have a nice day!

TwistedTwigleg

Hmm, well if the function is being called by an Area2D entered signal, then the only way it would be called twice is if two things enter at the same time. Just to check, can you add a print statement right before the yield? If it prints more than once then we can tell something is calling it multiple times but if it only prints once than something else is causing the issue.

tellheim

The Print prints indeed only once, I already tried this before I asked you guys. Lets see it in pictures:

Both items have their own scenes, their own scripts.

The Hero walks on a bomb. He has a signal when the bomb enters, and the bomb has a signal when the hero enteres. The bomb explodes, animation is played, works, bomb is queed.

Hero should die, and is queed, works, but the animation is not played, although the code is correct. Is there something wrong, the way I think things?

TwistedTwigleg

Okay, so its not a double call issue then, so we can fully rule that out.

Just to double check, there is an animation with the name “Dumm_gelaufen”, right? I’ve spent lots of time hunting down bugs that turned out to be just data setup, so while I doubt this is the case here, I feel it never hurts to be thorough. Though, if it was not setup then I imagine the yield wouldn’t work.

If you change the animation to something else does it play? That would help rule out of if the animation itself is causing the issue.

Another thing to check is whether a different animation is overriding it, like an idle animation or something. I imagine if this is the case you would see it though. Maybe try printing $AnimatedSprite.animation after the yield to make sure its the correct animation? Not sure if this would help or yield any useful information but it may help.

I’d offer more concrete suggestions, but I’m mostly just guessing at this point and trying to think of possible situations that would cause the animation to stop. I will keep thinking about the issue and potential solutions.

tellheim

Dear Twisted Twigleg

Crazy stuff: Yes, there is an animation called "Dumm_gelaufen". But: I followed your advice and put the Animation once again after the yield. As so:

func toedlich():
	if is_alive == false:
		spriteFlint.play("Dumm_gelaufen")
		yield(spriteFlint, "animation_finished")
		spriteFlint.play("Dumm_gelaufen")
		is_alive = true
		die()
#die has the function of counting and queuing

and it works absolutely fine! but not, if I delete the first animation in front of the yield. The sprite:Flint is called twice, and the hero walks on the bomb, the bomb explodes and the hero dies.

I am so glad. But honestly, I absolutely can not understand "why" it is working now. Does not seem logical to me. But anyway, thanks a lot for your constructive help.

have a nice day! best regards. tellheim

tellheim

sorry for the BIG Letters above. I did not know, that the hashtag makes the letters big.... it should be hashtag die has the function of counting and queuing :-)

Megalomaniak

No worries, I've fixed the formatting in your previous post.

TwistedTwigleg

@tellheim said: Dear Twisted Twigleg

Crazy stuff: Yes, there is an animation called "Dumm_gelaufen". But: I followed your advice and put the Animation once again after the yield. As so:
func toedlich():
	if is_alive == false:
		spriteFlint.play("Dumm_gelaufen")
		yield(spriteFlint, "animation_finished")
		spriteFlint.play("Dumm_gelaufen")
		is_alive = true
		die()
#die has the function of counting and queuing 
and it works absolutely fine! but not, if I delete the first animation in front of the yield. The sprite:Flint is called twice, and the hero walks on the bomb, the bomb explodes and the hero dies.

I am so glad. But honestly, I absolutely can not understand "why" it is working now. Does not seem logical to me. But anyway, thanks a lot for your constructive help.

have a nice day! best regards. tellheim

Awesome, I'm glad it works now! :smile: