Godot 2/Godot 3 script problem

LuanSantos95

Good night everyone.

A past topic helped me about a driver problem. Now the problem is that I imported a project made in Godot 2 to Godot 3 and the script has a lot of functions that changed names at this new version. In this moment the error is right here.

The script is right here:

extends KinematicBody2D

# This is a simple collision demo showing how
# the kinematic controller works.
# move() will allow to move the node, and will
# always move it to a non-colliding spot,
# as long as it starts from a non-colliding spot too.

# Member variables
const GRAVITY = 500.0 # Pixels/second

# Angle in degrees towards either side that the player can consider "floor"
const FLOOR_ANGLE_TOLERANCE = 40
const WALK_FORCE = 600
const WALK_MIN_SPEED = 10
const WALK_MAX_SPEED = 200
const STOP_FORCE = 1300
const JUMP_SPEED = 350
const JUMP_MAX_AIRBORNE_TIME = 0.2

const SLIDE_STOP_VELOCITY = 1.0 # One pixel per second
const SLIDE_STOP_MIN_TRAVEL = 1.0 # One pixel

var velocity = Vector2()
var on_air_time = 100
var jumping = false

var prev_jump_pressed = false

var nova_anim = ""
var animacao = ""

func _fixed_process(delta):
	# Create forces
	var force = Vector2(0, GRAVITY)
	
	var walk_left = Input.is_action_pressed("move_left")
	var walk_right = Input.is_action_pressed("move_right")
	var jump = Input.is_action_pressed("jump")
	
	var stop = true
	
	if (walk_left):
		if (velocity.x <= WALK_MIN_SPEED and velocity.x > -WALK_MAX_SPEED):
			force.x -= WALK_FORCE
			stop = false
	elif (walk_right):
		if (velocity.x >= -WALK_MIN_SPEED and velocity.x < WALK_MAX_SPEED):
			force.x += WALK_FORCE
			stop = false
	
	if (stop):
		var vsign = sign(velocity.x)
		var vlen = abs(velocity.x)
		
		vlen -= STOP_FORCE*delta
		if (vlen < 0):
			vlen = 0
		
		velocity.x = vlen*vsign
	
	# Integrate forces to velocity
	velocity += force*delta
	
	# Integrate velocity into motion and move
	var motion = velocity*delta
	
	# Move and consume motion
	motion = move_and_slide(motion)
	
	var floor_velocity = Vector2()
	
	if (is_on_floor()):
		# You can check which tile was collision against with this
		# print(get_collider_metadata())
		
		# Ran against something, is it the floor? Get normal
		var n = get_slide_count()
		
		if (rad2deg(acos(n.dot(Vector2(0, -1)))) < FLOOR_ANGLE_TOLERANCE):
			# If angle to the "up" vectors is < angle tolerance
			# char is on floor
			on_air_time = 0
			floor_velocity = get_collider_velocity()
		
		if (on_air_time == 0 and force.x == 0 and get_travel().length() < SLIDE_STOP_MIN_TRAVEL and abs(velocity.x) < SLIDE_STOP_VELOCITY and get_collider_velocity() == Vector2()):
			# Since this formula will always slide the character around, 
			# a special case must be considered to to stop it from moving 
			# if standing on an inclined floor. Conditions are:
			# 1) Standing on floor (on_air_time == 0)
			# 2) Did not move more than one pixel (get_travel().length() < SLIDE_STOP_MIN_TRAVEL)
			# 3) Not moving horizontally (abs(velocity.x) < SLIDE_STOP_VELOCITY)
			# 4) Collider is not moving
			
			revert_motion()
			velocity.y = 0.0
		else:
			# For every other case of motion, our motion was interrupted.
			# Try to complete the motion by "sliding" by the normal
			motion = n.slide(motion)
			velocity = n.slide(velocity)
			# Then move again
			move_and_slide(motion)
	
	if (floor_velocity != Vector2()):
		# If floor moves, move with floor
		move_and_slide(floor_velocity*delta)
	
	if (jumping and velocity.y > 0):
		# If falling, no longer jumping
		jumping = false
	
	if (on_air_time < JUMP_MAX_AIRBORNE_TIME and jump and not prev_jump_pressed and not jumping):
		# Jump must also be allowed to happen if the character left the floor a little bit ago.
		# Makes controls more snappy.
		velocity.y = -JUMP_SPEED
		jumping = true
	
	on_air_time += delta
	prev_jump_pressed = jump

	var chao = get_node("rayChao").is_on_floor() || get_node("rayChao1").is_on_floor()
	
	var andando = walk_right || walk_left
	
	if andando:
		if velocity.x > 0:
			get_node("sprite").set_flip_h(false)
		else:
			get_node("sprite").set_flip_h(true)
	
	if chao:
		if andando:
			nova_anim = "walking"
		else:
			nova_anim = "stopped"
	else: #está saltando
		if velocity.y < 0: #saltando
			nova_anim = "jumping"
		else: #caindo
			nova_anim = "falling"
		pass
	
	if animacao != nova_anim:
		get_node("anim").play(nova_anim)
		animacao = nova_anim

func _ready():
	set_fixed_process(true)

DaveTheCoder

get_travel() is a getter method for the property travel of KinematicCollision2D. https://docs.godotengine.org/en/stable/classes/class_kinematiccollision2d.html#class-kinematiccollision2d-property-travel

KinematicBody2::move_and_collide() returns a KinematicCollision2D.

I don't see a KinematicCollision2D instance in that script.

LuanSantos95

If I use KinematicCollision2D instead of KinematicBody2D will I be still capable of use KinematicBody2D properties?

The debugger says that I can't use two extends at the same time.

DaveTheCoder

No, that wouldn't make sense. A KinematicCollision2D contains collision data for KinematicBody2D collisions.

I've never used Godot 2, and I don't understand your code well enough to know how to fix it.

Could you replace move_and_slide() with move_and_collide()? That would provide you with a KinematicCollision2D.

LuanSantos95

@DaveTheCoder said: No, that wouldn't make sense. A KinematicCollision2D contains collision data for KinematicBody2D collisions.

I see.

I've never used Godot 2, and I don't understand your code well enough to know how to fix it.

No problem, at least you're trying to help me.

Could you replace move_and_slide() with move_and_collide()? That would provide you with a KinematicCollision2D.

Unfortunely, It didn't work :(

DaveTheCoder

You'll need to do more than simply replace "move_and_slide" with "move_and_collide". That's just an idea to start with.

TwistedTwigleg

You can get a KinematicCollision2D using move_and_slide by calling get_slide_collision and passing the slide collision you want. Generally just using the first slide is fine though, but you'll want to check if there was a slide before trying to get the data.

Something like this would work and get you access to the KinematicCollision2D from move_and_slide if there was a collision:

var slide_collision_data = null
if (get_slide_count() > 0):
	slide_collision_data = get_slide_collision(0)

if (slide_collision_data != null):
	print ("Travel is: ", slide_collision_data.travel)

TwistedTwigleg

To fix the script, you will need to make a few minor adjustments. Here's the script in the OP, adjusted to use get_slide_collision:

extends KinematicBody2D

# This is a simple collision demo showing how
# the kinematic controller works.
# move() will allow to move the node, and will
# always move it to a non-colliding spot,
# as long as it starts from a non-colliding spot too.

# Member variables
const GRAVITY = 500.0 # Pixels/second

# Angle in degrees towards either side that the player can consider "floor"
const FLOOR_ANGLE_TOLERANCE = 40
const WALK_FORCE = 600
const WALK_MIN_SPEED = 10
const WALK_MAX_SPEED = 200
const STOP_FORCE = 1300
const JUMP_SPEED = 350
const JUMP_MAX_AIRBORNE_TIME = 0.2

const SLIDE_STOP_VELOCITY = 1.0 # One pixel per second
const SLIDE_STOP_MIN_TRAVEL = 1.0 # One pixel

var velocity = Vector2()
var on_air_time = 100
var jumping = false

var prev_jump_pressed = false

var nova_anim = ""
var animacao = ""

func _fixed_process(delta):
	# Create forces
	var force = Vector2(0, GRAVITY)
	
	var walk_left = Input.is_action_pressed("move_left")
	var walk_right = Input.is_action_pressed("move_right")
	var jump = Input.is_action_pressed("jump")
	
	var stop = true
	
	if (walk_left):
		if (velocity.x <= WALK_MIN_SPEED and velocity.x > -WALK_MAX_SPEED):
			force.x -= WALK_FORCE
			stop = false
	elif (walk_right):
		if (velocity.x >= -WALK_MIN_SPEED and velocity.x < WALK_MAX_SPEED):
			force.x += WALK_FORCE
			stop = false
	
	if (stop):
		var vsign = sign(velocity.x)
		var vlen = abs(velocity.x)
		
		vlen -= STOP_FORCE*delta
		if (vlen < 0):
			vlen = 0
		
		velocity.x = vlen*vsign
	
	# Integrate forces to velocity
	velocity += force*delta
	
	# Integrate velocity into motion and move
	var motion = velocity*delta
	
	# Move and consume motion
	motion = move_and_slide(motion)
	
	var floor_velocity = Vector2()
	
	# NEW - get the slide collision data, if it exists
	var slide_collision_data = null
	if (get_slide_count() > 0):
		slide_collision_data = get_slide_collision(0)
	
	# NEW - make sure we have slide collision data. Shouldn't be necessary due to using is_on_floor, but never hurts to make sure
	if (is_on_floor() and side_collision_data != null):
		# You can check which tile was collision against with this
		# print(get_collider_metadata())
		
		# Ran against something, is it the floor? Get normal
		#var n = get_slide_count()
		# NEW - the code above does not return the normal. This new code does
		var n  = slide_collision_data.normal
		
		if (rad2deg(acos(n.dot(Vector2(0, -1)))) < FLOOR_ANGLE_TOLERANCE):
			# If angle to the "up" vectors is < angle tolerance
			# char is on floor
			on_air_time = 0
			floor_velocity = get_collider_velocity()
		
		#if (on_air_time == 0 and force.x == 0 and get_travel().length() < SLIDE_STOP_MIN_TRAVEL and abs(velocity.x) < SLIDE_STOP_VELOCITY and get_collider_velocity() == Vector2()):
		# NEW - commented out IF statement above and adjusted it to use side_collision_data
		if (on_air_time == 0 and force.x == 0 and slide_collision_data.travel.length() < SLIDE_STOP_MIN_TRAVEL and abs(velocity.x) < SLIDE_STOP_VELOCITY and side_collision_data.collider_velocity == Vector2()):
			# Since this formula will always slide the character around, 
			# a special case must be considered to to stop it from moving 
			# if standing on an inclined floor. Conditions are:
			# 1) Standing on floor (on_air_time == 0)
			# 2) Did not move more than one pixel (get_travel().length() < SLIDE_STOP_MIN_TRAVEL)
			# 3) Not moving horizontally (abs(velocity.x) < SLIDE_STOP_VELOCITY)
			# 4) Collider is not moving
			
			revert_motion()
			velocity.y = 0.0
		else:
			# For every other case of motion, our motion was interrupted.
			# Try to complete the motion by "sliding" by the normal
			motion = n.slide(motion)
			velocity = n.slide(velocity)
			# Then move again
			move_and_slide(motion)
	
	if (floor_velocity != Vector2()):
		# If floor moves, move with floor
		move_and_slide(floor_velocity*delta)
	
	if (jumping and velocity.y > 0):
		# If falling, no longer jumping
		jumping = false
	
	if (on_air_time < JUMP_MAX_AIRBORNE_TIME and jump and not prev_jump_pressed and not jumping):
		# Jump must also be allowed to happen if the character left the floor a little bit ago.
		# Makes controls more snappy.
		velocity.y = -JUMP_SPEED
		jumping = true
	
	on_air_time += delta
	prev_jump_pressed = jump

	var chao = get_node("rayChao").is_on_floor() || get_node("rayChao1").is_on_floor()
	
	var andando = walk_right || walk_left
	
	if andando:
		if velocity.x > 0:
			get_node("sprite").set_flip_h(false)
		else:
			get_node("sprite").set_flip_h(true)
	
	if chao:
		if andando:
			nova_anim = "walking"
		else:
			nova_anim = "stopped"
	else: #está saltando
		if velocity.y < 0: #saltando
			nova_anim = "jumping"
		else: #caindo
			nova_anim = "falling"
		pass
	
	if animacao != nova_anim:
		get_node("anim").play(nova_anim)
		animacao = nova_anim

func _ready():
	set_fixed_process(true)

Though looking at the code, it seems like one of the Godot demo projects. Have you looked at the Godot 3 demo projects on GitHub, you can probably find a Godot 3 version of the demo there if you are using a demo project code.

LuanSantos95

@DaveTheCoder said: You'll need to do more than simply replace "move_and_slide" with "move_and_collide". That's just an idea to start with.

Yeah, I thought so.

@TwistedTwigleg said: To fix the script, you will need to make a few minor adjustments. Here's the script in the OP, adjusted to use get_slide_collision:

extends KinematicBody2D

# This is a simple collision demo showing how
# the kinematic controller works.
# move() will allow to move the node, and will
# always move it to a non-colliding spot,
# as long as it starts from a non-colliding spot too.

# Member variables
const GRAVITY = 500.0 # Pixels/second

# Angle in degrees towards either side that the player can consider "floor"
const FLOOR_ANGLE_TOLERANCE = 40
const WALK_FORCE = 600
const WALK_MIN_SPEED = 10
const WALK_MAX_SPEED = 200
const STOP_FORCE = 1300
const JUMP_SPEED = 350
const JUMP_MAX_AIRBORNE_TIME = 0.2

const SLIDE_STOP_VELOCITY = 1.0 # One pixel per second
const SLIDE_STOP_MIN_TRAVEL = 1.0 # One pixel

var velocity = Vector2()
var on_air_time = 100
var jumping = false

var prev_jump_pressed = false

var nova_anim = ""
var animacao = ""

func _fixed_process(delta):
	# Create forces
	var force = Vector2(0, GRAVITY)
	
	var walk_left = Input.is_action_pressed("move_left")
	var walk_right = Input.is_action_pressed("move_right")
	var jump = Input.is_action_pressed("jump")
	
	var stop = true
	
	if (walk_left):
		if (velocity.x <= WALK_MIN_SPEED and velocity.x > -WALK_MAX_SPEED):
			force.x -= WALK_FORCE
			stop = false
	elif (walk_right):
		if (velocity.x >= -WALK_MIN_SPEED and velocity.x < WALK_MAX_SPEED):
			force.x += WALK_FORCE
			stop = false
	
	if (stop):
		var vsign = sign(velocity.x)
		var vlen = abs(velocity.x)
		
		vlen -= STOP_FORCE*delta
		if (vlen < 0):
			vlen = 0
		
		velocity.x = vlen*vsign
	
	# Integrate forces to velocity
	velocity += force*delta
	
	# Integrate velocity into motion and move
	var motion = velocity*delta
	
	# Move and consume motion
	motion = move_and_slide(motion)
	
	var floor_velocity = Vector2()
	
	# NEW - get the slide collision data, if it exists
	var slide_collision_data = null
	if (get_slide_count() > 0):
		slide_collision_data = get_slide_collision(0)
	
	# NEW - make sure we have slide collision data. Shouldn't be necessary due to using is_on_floor, but never hurts to make sure
	if (is_on_floor() and side_collision_data != null):
		# You can check which tile was collision against with this
		# print(get_collider_metadata())
		
		# Ran against something, is it the floor? Get normal
		#var n = get_slide_count()
		# NEW - the code above does not return the normal. This new code does
		var n  = slide_collision_data.normal
		
		if (rad2deg(acos(n.dot(Vector2(0, -1)))) < FLOOR_ANGLE_TOLERANCE):
			# If angle to the "up" vectors is < angle tolerance
			# char is on floor
			on_air_time = 0
			floor_velocity = get_collider_velocity()
		
		#if (on_air_time == 0 and force.x == 0 and get_travel().length() < SLIDE_STOP_MIN_TRAVEL and abs(velocity.x) < SLIDE_STOP_VELOCITY and get_collider_velocity() == Vector2()):
		# NEW - commented out IF statement above and adjusted it to use side_collision_data
		if (on_air_time == 0 and force.x == 0 and slide_collision_data.travel.length() < SLIDE_STOP_MIN_TRAVEL and abs(velocity.x) < SLIDE_STOP_VELOCITY and side_collision_data.collider_velocity == Vector2()):
			# Since this formula will always slide the character around, 
			# a special case must be considered to to stop it from moving 
			# if standing on an inclined floor. Conditions are:
			# 1) Standing on floor (on_air_time == 0)
			# 2) Did not move more than one pixel (get_travel().length() < SLIDE_STOP_MIN_TRAVEL)
			# 3) Not moving horizontally (abs(velocity.x) < SLIDE_STOP_VELOCITY)
			# 4) Collider is not moving
			
			revert_motion()
			velocity.y = 0.0
		else:
			# For every other case of motion, our motion was interrupted.
			# Try to complete the motion by "sliding" by the normal
			motion = n.slide(motion)
			velocity = n.slide(velocity)
			# Then move again
			move_and_slide(motion)
	
	if (floor_velocity != Vector2()):
		# If floor moves, move with floor
		move_and_slide(floor_velocity*delta)
	
	if (jumping and velocity.y > 0):
		# If falling, no longer jumping
		jumping = false
	
	if (on_air_time < JUMP_MAX_AIRBORNE_TIME and jump and not prev_jump_pressed and not jumping):
		# Jump must also be allowed to happen if the character left the floor a little bit ago.
		# Makes controls more snappy.
		velocity.y = -JUMP_SPEED
		jumping = true
	
	on_air_time += delta
	prev_jump_pressed = jump

	var chao = get_node("rayChao").is_on_floor() || get_node("rayChao1").is_on_floor()
	
	var andando = walk_right || walk_left
	
	if andando:
		if velocity.x > 0:
			get_node("sprite").set_flip_h(false)
		else:
			get_node("sprite").set_flip_h(true)
	
	if chao:
		if andando:
			nova_anim = "walking"
		else:
			nova_anim = "stopped"
	else: #está saltando
		if velocity.y < 0: #saltando
			nova_anim = "jumping"
		else: #caindo
			nova_anim = "falling"
		pass
	
	if animacao != nova_anim:
		get_node("anim").play(nova_anim)
		animacao = nova_anim

func _ready():
	set_fixed_process(true)

The previous problem was solved, thanks a lot! However, the get_collider_velocity() function isn't recognized. I commented it and others functions aren't recognized too.

About the code, yeah, I used a YouTube tutorial that gives a premade one, but like I said, it was on Godot 2. I didn't find the original code at this Github profile, but I'll look once more until I find a generic platformer player code.

Thanks again!

EDIT:

WOW THAT'S AN AWESOME REPOSITORY! I will save it here and try some tests here. It will help a lot!