Attack Animation stuck on first frame.

ChillingPixel

Hey everyone I am trying to make a 2d platformer and I am having a problem where when I trigger my attack, it gets stuck on the first frame then goes back to my idle animation. I know that the idle animation is interfering with it, but I don't know how to fix it. I have tried adding a custom "is_attacking" function but it doesn't help. I have checked the forum and saw a few people with similar/the exact same issue and tried their solutions with out any help.

I could really use the help.

extends KinematicBody2D

# Setting speed and gravity
export (int) var speed = 150
export (int) var jump_speed = -550
export (int) var gravity = 1500

var is_on_ground = false
var is_attacking = false

var velocity = Vector2.ZERO

# MOVEMENT
func get_input():
	velocity.x = 0
	# RIGHT
	if Input.is_action_pressed("right"):
		velocity.x = speed
		$AnimatedSprite.flip_h = false
		if is_on_ground == true:
			$AnimatedSprite.play("run")
	# LEFT
	if Input.is_action_pressed("left"):
		velocity.x = -speed
		$AnimatedSprite.flip_h = true
		if is_on_ground == true:
			$AnimatedSprite.play("run")
	# JUMP
	if Input.is_action_pressed("up"):
		$AnimatedSprite.play("jump")
		if is_on_ground:
			velocity.y = jump_speed
	# IDLE
	if velocity.x == 0:
		if is_on_ground == true:
			$AnimatedSprite.play("idle")
	# ATTACK
	if Input.is_action_pressed("lclick"):
		if is_on_ground == true:
			$AnimatedSprite.stop()
			$AnimatedSprite.play("attack")
# Gravity/velocity
func _physics_process(delta):
	get_input()
	velocity.y += gravity * delta
	velocity = move_and_slide(velocity, Vector2.UP)
	if is_on_floor():
		is_on_ground = true
	else:
		is_on_ground = false

cybereality

Well you probably want to use states eventually, if you logic get's more complex. For now, you can just add a boolean value to track when you are attacking, like you are with the floor.

# IDLE
    if velocity.x == 0:
        if is_on_ground == true and not is_attacking:
            $AnimatedSprite.play("idle")
    # ATTACK
    if Input.is_action_pressed("lclick"):
        if is_on_ground == true:
            $AnimatedSprite.stop()
            $AnimatedSprite.play("attack")
            is_attacking = true

Then you will need a timer or some way to set is_attacking to false after the animation is done.

ChillingPixel

@cybereality said: Well you probably want to use states eventually, if you logic get's more complex. For now, you can just add a boolean value to track when you are attacking, like you are with the floor.
# IDLE
    if velocity.x == 0:
        if is_on_ground == true and not is_attacking:
            $AnimatedSprite.play("idle")
    # ATTACK
    if Input.is_action_pressed("lclick"):
        if is_on_ground == true:
            $AnimatedSprite.stop()
            $AnimatedSprite.play("attack")
            is_attacking = true
Then you will need a timer or some way to set is_attacking to false after the animation is done.

Weird. That is actually the first solution I tried, except I declared the var at the start of the script and updated it when attacking. I also just made a seperate if statement because I tried doing

if is_on ground == true and is_attacking == false:
...

I came from python so GDScript is a little different. Thanks for your help.

cybereality

Cool. Glad I was able to help.

Megalomaniak

Saw the flag in moderation dashboard. No, discussions don't need to be closed. I think you are confused since if the topic was a question rather than discussion type then you'd see the option to mark a reply as an answer.

On that note, this topic would have fit well as a question so I'll change the topic type. ;)