triggers twice sometimes

daime2861

func _on_token_area_entered(area):
   	 if area.collision_layer==1:
       	print("triggered")
        	gui.plus_token()
        	gui.create_token()
        	gui.reset_kills()
        	gui._spawn_enemies()
        	self.queue_free()

not always. 1 of 3 times. i only have "spaw_enemies()" here and in gui-ready() could it be, that it's recreated. can i check it?

Megalomaniak

Are you sure it triggers twice during a single frame? It could be triggering on two different frames in a row perhaps? You could try toggling a breakpoint for it and stepping through the breakpoints to confirm.

daime2861

@Megalomaniak said: Are you sure it triggers twice during a single frame? It could be triggering on two different frames in a row perhaps? You could try toggling a breakpoint for it and stepping through the breakpoints to confirm.

i did. it goes trough print(triggered) and spawn_enemies() twice

Megalomaniak

Hmm, maybe a check to see if an enemy was already spawned and if so then just pass?

daime2861

@Megalomaniak said: Hmm, maybe a check to see if an enemy was already spawned and if so then just pass?

i did

func _on_crown_area_entered(area):
    if area.collision_layer==1:
        var enemy = get_tree().root.find_node("enemy")
        if enemy == null:
            gui.reset_kills()
            gui._spawn_enemies()
        gui.plus_token()
        gui.create_token()    
        self.queue_free()

but enemies spawn twice could you say how to spawn

func _spawn_enemies():
	enemy_pos.shuffle()
	cannon_pos.shuffle()
	for i in 5:
		var scene = load("res://scenes/enemy.tscn")
		var scene_instance = scene.instance()
		get_tree().root.add_child(scene_instance)
		scene_instance.position=enemy_pos[i-1]
	for i in spawn_cannnons:
		var scene = load("res://scenes/cannon.tscn")
		var scene_instance = scene.instance()
		get_tree().root.add_child(scene_instance)
		scene_instance.position=cannon_pos[i-1]

TwistedTwigleg

I'd suggest adding a boolean so it cannot trigger more than once, since you are freeing the node afterwards. Something like this:

var is_crown_triggered = false
func _on_crown_area_entered(area):
	if (is_crown_triggered == true):
		return
	
	if (area.collision_layer == 1):
		print("triggered")
		gui.plus_token()
		gui.create_token()
		gui.reset_kills()
		gui._spawn_enemies()
		self.queue_free()
		is_crown_triggered = true

daime2861

var enemy = get_tree().root.find_node("enemy", TRUE, FALSE) added, now works, but I don't understand why

daime2861

@TwistedTwigleg said: I'd suggest adding a boolean so it cannot trigger more than once, since you are freeing the node afterwards. Something like this:
var is_crown_triggered = false
func _on_crown_area_entered(area):
	if (is_crown_triggered == true):
		return
	
	if (area.collision_layer == 1):
		print("triggered")
		gui.plus_token()
		gui.create_token()
		gui.reset_kills()
		gui._spawn_enemies()
		self.queue_free()
		is_crown_triggered = true

yes, thank you

daime2861

collision mask in both objects