Assigning a character movement to player 1 or player 2 controls

DanySnowyman

Hi! I'm working in a 2D versus fighting game. I created some basic moves and interactions related to a standalone character and things go pretty well. Now, it's time to start testing with the two characters and here is where my doubts begin. I created an InputMap for two players. Something like P1_UP, P2_UP, P1_PUNCH, P2_PUNCH and so... The code for the character uses "if Input.is_action_pressed.("P1_UP")..." for all the movement stuff. When I call a character for the selection screen I want to change a variable that determines the assigned player, and change all these "P1..." for "P2..." I'm not really sure how to do. I found an interesting method in YouTube https://youtube.com/watch?v=QsfG8J50hP8 and I can say that it works pretty well, but I'm wondering if there is some other more ellegant way to do this instead of all of these ("P%s_UP", % player). I did some researching and I did'nt found some much else that helps me. I think I can do too a copy of the script changing all of the P1 by P2 and load one or another at the time the character is selected. Is there some more straightforward method to solve this? Thanks in advance.

TwistedTwigleg

Well, I'm not sure its more elegant, but you could cache the string (var PStr = "P%" % player) and then use the cached string in the Input function calls (if Input.is_action_pressed(PStr+"_UP")). Outside of that, I'm not sure on what else could be done right off. I'll keep thinking on it in the background and will post if I think of something.

DanySnowyman

Thanks. It's a little better. But I wonder if I could be some way to make InputMaps that could be used by any player by changing the device we want to listen. Some like "if Input.is_action_pressed(device(0), "UP") or anything like that. It's hard to believe there'll no easiest option besides of making two InputsMaps exacts in everything but the Device number. Or changing all these lines of code depending of the player. In my case is for two players, but it could be too much complex if more players needed.

Another bad thing about this is that ruins entirely the autocompletion feature for typing inputs, favoring making mistakes.

TwistedTwigleg

@DanySnowyman said: Thanks. It's a little better. But I wonder if I could be some way to make InputMaps that could be used by any player by changing the device we want to listen. Some like "if Input.is_action_pressed(device(0), "UP") or anything like that. It's hard to believe there'll no easiest option besides of making two InputsMaps exacts in everything but the Device number. Or changing all these lines of code depending of the player. In my case is for two players, but it could be too much complex if more players needed.

I don't know, but that would be an interesting way to solve the issue that would make the code easier to maintain and straightforward when reading. Unfortunately, I'm not sure there is anything like that in Godot currently.

Another bad thing about this is that ruins entirely the autocompletion feature for typing inputs, favoring making mistakes.

Yeah, that is a downside! I've made a few mistakes due to lack of auto completion before :sweat_smile:

DanySnowyman

Tried your solution this morning. Something goes wrong beacuse the Input (PStr+"_UP") part is not accepted by Godot. Or maybe the problem is the variable itself. I thinked on it and I find another possibly solution. It consist in make two functions, "player_1_control(delta)" and "player_2_control(delta)" and use an "if" in the process(delta) for using one or another depending of the variable "player". The counterpart of this is that I need to be sure of maintain exact copys of the two "player_controls(delta)", wich is an annoyance for the actual estate of the code, still exposed to constant trial and error.