Coding novice - Problem reading a variable from another function

CarapaceonBear

This is a super basic problem, I'm sure. I'm using a gridmap for a tower-defence style game. I'm close to getting it to work, but can't get the building's ID to go through to the function that needs it.

I have 2 buttons for selecting which building to place.

func _on_Building_1_pressed():
	is_building = true
	building_ID = 0	
func _on_Building_2_pressed():
	is_building = true
	building_ID = 1

This is the section of the _physics_process where the building_ID is called.

	if is_building = true and Input.is_action_pressed("mouse_select"):
		_place_building(building_ID)
	if is_building = true and Input.is_action_pressed("mouse_cancel"):
		is_building = false

This is the building placement code, which works fine if I manually set the ID to either 0 or 1

func _place_building(ID):
	match ID:
		0:
			var building = building_1.instance()
			building.translation = selection_position
			$BuildingContainer.add_child(building)
		1:
			var building = building_2.instance()
			building.translation = selection_position
			$BuildingContainer.add_child(building)
	map.set_cell_item(point.x, point.y, point.z, 90)

My question is how I let the _physics_process read the 'building_ID' from the button press functions. The 'is_building' bool is working just fine.

Thanks for taking the time to read, and have a lovely day.

TwistedTwigleg

Welcome to the forums @CarapaceonBear!

How is building_ID defined? Is it a class variable (a variable defined outside of all functions)? Also, what is happening when you call the _place_building function?

CarapaceonBear

I've defined building_ID as a variable at the top of the code. I establish it as = 0 in the beginning.

var building_ID = 0

What happens when I call the _place_building function is that an instance of the building, saved as a separate scene, is spawned and placed in the level on the gridmap tile which corresponds to the mouse position. This is working fine, however the building which is placed is the one with ID of 0, regardless of which UI button I press to trigger it. If I manually change building_ID = 1 (which I'm trying to make happen when the second button is pressed), then the correct building is placed in the scene when I call _place_building

TwistedTwigleg

Is the second button pressed signal correctly attached/connected to the _on_Building_2_pressed function? That would be my guess as to what could, potentially, be causing the issue.

CarapaceonBear

It looks like that is what's causing the problem! I had both buttons print a different output to check, and pressing both caused the output from button 1. I guess this is because I was lazy and duplicated the first button, instead of making a fresh one for button 2? Thanks so much for figuring that out! I'm glad it was a simple fix in the end.