erase function of string don't work if the string is in a array

HansWurst

Hello, I think the problem is well described in the title. In addition I have a short sample.

func _ready():
	var string_var = "StringX"
	print(string_var)
	string_var.erase(3, 3) # work
	print(string_var)	
	
	var string_array = []
	string_array.append("String1")
	string_array.append("String2")
	string_array.append("String3")
	
	for string in string_array:
		print(string)
		
	for string in string_array:
		string.erase(3, 3) # don't work
	
	for string in string_array:
		print(string)
		
	for i in range(0, string_array.size()):
		string_array[i].erase(3, 3) # don't work
	
	for string in string_array:
		print(string)

	# workaround
	for i in range(0, string_array.size()):
		string_array[i] = string_array[i].substr(0, 3) + string_array[i].substr(6, -1)  # work
	
	for string in string_array:
		print(string)

what do I wrong? Thanks

TwistedTwigleg

The following code works for me:

for i in range(0, string_array.size()):
	var current_string = string_array[i]
	current_string.erase(3, 3)
	string_array[i] = current_string

I think the issue is that the string returned when using the for loop is a copy, so after performing whatever operations you want, you need to override the string at the index position with the new string data.

HansWurst

Thanks. Your workaround looks definitely better than mine.

Your explanation sounds logical for this sample

for string in string_array:
	string.erase(3, 3)

But I think it is strange, that this don't work too.

for i in range(0, string_array.size()):
	string_array[i].erase(3, 3)

Thank you.

TwistedTwigleg

No problem, happy to help :smile:

I think the reason the second code snippet does not work is because string_array[i] returns an instance of the data at the position, rather than a pointer to the data itself. Though, it is not what I would expect given my experience with other programming languages, but Godot's array stuff has quirks, based on my experience.