World generation

UnknownUser

Hello. The most difficult moment for me has come - the random generation of the world. The player walks forward and objects are randomly created in front of him. I sketched the code that I pushed into _physics_procces and realized that this method is very bad, maybe you have better ways?

When the player walks about 1000 meters, I use this code again and I have lags:

        func _physics_procces(delta):
            if $Player.global_position.distanse_to(getpoint) >= 1000:
		        getpoint = $Player.global_position
		        var map1
		        var pos1 = $Player.global_position.x
	        	var pos2 = $Player.global_position.y+1000
	        	for i in 200:
	        		map1 = Map1.instance()
	        		add_child(map1)
	        		map1.global_position = Vector2(
	        								rng.randf_range(
	        									pos1 - 1500, 
	        									pos1 + 1500), 
	        								rng.randf_range(
	        									pos2 + 500, 
	        									pos2 + 1500)
	        								)
	        	pos1 = $Player.global_position.x
	        	pos2 = $Player.global_position.y-1000
	        	for i in 200:
	        		map1 = Map1.instance()
	        		add_child(map1)
	        		map1.global_position = Vector2(
	        								rng.randf_range(
	        									pos1 - 1500, 
	        									pos1 + 1500), 
	        								rng.randf_range(
	        									pos2 - 500, 
	        									pos2 - 1500)
	        								)
	        	pos1 = $Player.global_position.x+1000
	        	pos2 = $Player.global_position.y
	        	for i in 200:
	        		map1 = Map1.instance()
	        		add_child(map1)
	        		map1.global_position = Vector2(
	        								rng.randf_range(
	        									pos1 + 500, 
	        									pos1 + 1500), 
	        								rng.randf_range(
	        									pos2 - 2500, 
	        									pos2 + 2500)
	        								)
	        	pos1 = $Player.global_position.x-1000
	        	pos2 = $Player.global_position.y
	        	for i in 200:
	        		map1 = Map1.instance()
	        		add_child(map1)
	        		map1.global_position = Vector2(
	        								rng.randf_range(
	        									pos1 - 500, 
	        									pos1 - 1500), 
	        								rng.randf_range(
	        									pos2 - 2500, 
	        									pos2 + 2500)
	        								)

Megalomaniak

Likely unrelated to the lag but there seems to be a typo on line 2:

if $Player.global_position.distanse_to(getpoint) >= 1000: should probably be: if $Player.global_position.distance_to(getpoint) >= 1000:

As for physics process(or process for that matter), it's probably not where you want to do this. Maybe create a function that can be called either deferred or via some custom queuing logic so as to batch updates and process them in chunks. Preferably in a separate thread perhaps?

Also actively creating and removing nodes can be more expensive, maybe create the objects upfront but have them be invisible, and just manage their locations, visibility and any custom states as need be. By custom states I mean for an example containers that spawn a loot roll.

If it's opened it can't roll new loot, when you hide it set it to invisible it gets reinitialized so it can be opened again as another container again? Maybe something like that...