Instantiating a pickup won't work.

UnknownUser

Hi, I code in GDScript. I've been trying to instantiate pickups into my game to make the level making process alot easier, but the pickups won't show up, and when they do, I then can't use them. I will put my code below for anyone to check, but I'm pretty confused, as I haven't struggled with instantiating before.

CODE

var ppus = preload("res://Peanut pickup.tscn")

func _ready():
	var ppus_instance = ppu.instance()
	ppus_instance.position = $Peanut_pickup_spawn1.get_global_position()              #the $Peanut_pickup_spawn1 node is a child 		 
                                                                                                                                                                                         node of the player.
	ppus_instance.rotation_degrees = 0
	get_tree().get_root().call_deferred("add_child", ppus_instance)

And then the code for the pickup that I am trying to instantiate:

extends Area2D

var player_inside = false

signal peanut_picked_up

func _ready():
	show()
	
func _physics_process(delta):
	if Input.is_action_pressed("pickup"):
		if player_inside:
			emit_signal("peanut_picked_up")
			hide()
			queue_free()
		else:
			pass
	else:
		inside_check()



func _on_Peanut_Pickup_area_entered(area):
	player_inside = true
	$AnimationPlayer.play("on player entered")

Any suggestions would be greatly appreciated. I probably won't get back to you for about a week, as I am going on holiday without my laptop. Sorry and thank you :)

UnknownUser

Oh- the word format has gotten rid of all my indentations as well for some reason. They are there in the code, so that won't be why.

TwistedTwigleg

@UnrulyElf10 said: Oh- the word format has gotten rid of all my indentations as well for some reason. They are there in the code, so that won't be why.

I fixed it. It just wasn't marked to format itself as code. I just indented all of the code by a single tab to fix the issue :smile:

UnknownUser

Oh- thanks @TwistedTwigleg :)

UnknownUser

Okay- I'm now back from holiday but have no replies... Hmm

Megalomaniak

@UnrulyElf10 said:

CODE

	var ppus = preload("res://Peanut pickup.tscn")
	
	func _ready():
		var ppus_instance = ppu.instance()

Where does the ppu come from?

UnknownUser

ah. hmm. I think that ppu.instance() is supposed to be ppus.instance()

UnknownUser

Where does the ppu come from?

I have now tried that and it still doesn't work. I am trying to instantiate 3 peanuts, however only one shows up. When I pick that one up, it doesn't register my pickup or anything like that, so I am unable to even use this pickup. I may just forget this whole thing unless anyone can find anything that works.

TwistedTwigleg

Are you connecting the signals to the proper functions for collision detection? In the code snippets shown, there doesn’t appear to be any code that connects the signals, which could be why it doesn’t register the player picking them up.

You can use the connect function to connect signals in code, so for the peanut you could use something like this:

func _ready():
	connect(“area_entered”, self,  “_on_Peanut_Pickup_area_entered”)

And for the player:

ppus_instance.connect(“peanut_picked_up”, self, “_on_peanut_picked_up”)

And then you’d need a function called _on_peanut_picked_up (or something similar) for the signal to point to.

I’m not sure if the signals are the issue, but that’s what I would look into for fixing the lack of pickup registration. :smile: