How to I get these subdividing squares into the correct position?: Page 3

How to I get these subdividing squares into the correct position?

Haledire

woops, i typed that out wrong. it is node.queue_free() there.

if division > 4 applies to the smaller chunks, which would get fed into this function. This limits the production of "new" nodes. This only tells the last node that was given a division of 5 being fed into this function to remove itself. This has no bearing on nodes with division levels from 0 to 4, which will still exist because they don't get removed unless their level is 5.

You need to tell the original node to queue_free() unhindered by a requirement. the reason that queue_free() is in the if statement at all is because it's a necessary function of subdivide - it "has" to remove the node that was sent to it.

PopeRigby

You need to tell the original node to queue_free() unhindered by a requirement. the reason that queue_free() is in the if statement at all is because it's a necessary function of subdivide - it "has" to remove the node that was sent to it.

Yeah, okay. I thought I was already doing that though. Isn't it doing that right here:

func subdivide(node):
    var division = node.get_meta("level")
    if division > 4:
            node.queue_free() # <<<<<<<<<<<<<<<<<
            return
    var Stamp = node.duplicate()

Haledire

again - your original node never changes value - ie: it's division level is always 0 - why then would that node.queue_free() fire on that node?

var division = 0
if division > 4:
	do stuff <---- this code will never run

press subdivide - begin looping over children Subdivide takes in child(0) as node node has a level of 0 : ignore queue_free() because node's level is 0 finish function - node is still there finish loop

press subdivide - begin looping over children function starts again: feed in child(0) as node node still has a level of 0 : ignore queue_free() because node's level is 0 finish function - node is still there

nothing about subdivide changes the original node - there's no reason to. That if statement only works on later iterations of subdivide which gets an altered value for level.

PopeRigby

Oh I see. Is this how it's supposed to work if I have no mouse_entered connections set up? I'm just doing this right now:

func _input(event):
    if event.is_action_pressed("subdivide"):
        for child in get_children(): 
            subdivide(child)

Haledire

Yes - that's the expected result - original nodes leave, and the subdivided nodes keep generating until the 5th iteration, where they all get removed.

What you now have to do is set up each individiual node to connect the signal "mouse_entered" to the function "subdivide". Also - make sure you duplicate the shape of each Clone.get_node("CollisionShape2D").shape as right now, you only duplicate when you make the Stamp, meaning 4 objects are sharing the same shape at any given time.

Signal connections with code work like this: Node .connect( "signal from node", recieving node, "receiving function", [ array of binds ], Connection method)

What you need is to have the original node connect it's signal directly to the subdivide function, while passing a bind containing it's own reference.

$StaticBody2D.connect("mouse_entered", self, "subdivide", [$StaticBody2D], CONNECT_ONESHOT)

(The connection method here doesn't seem to be needed, but I'm paranoid with the connection here).

When the mouse enters the StaticBody2D, it will fire the function subdivide, and pass the bound value of the reference to the StaticBody2D.

This same connection method needs to be applied to each generated node as well:

Clone.connect("mouse_entered", self, "subdivide", [Clone], CONNECT_ONESHOT)

PopeRigby

Sweet! I think I got it mostly working now, but the divided pieces aren't splitting off of the main rigid body, so they don't have their own physics: https://watch.haddock.cc/videos/watch/15a37f6d-681b-44e2-9ea4-3eed4c7d2d87

I'm also getting those weird red squares.

extends Node2D

var min_extents = Vector2(1.25,1.25)
var extents = Vector2(100,100)
var sprite_scale

func _ready():
    $StaticBody2D.set_meta("level", 0)
    # warning-ignore:return_value_discarded
    $StaticBody2D.connect("mouse_entered", self, "subdivide", [$StaticBody2D], CONNECT_ONESHOT)
    sprite_scale = $StaticBody2D/CollisionShape2D/Sprite.scale.x / 10
        
func subdivide(node):
    node.queue_free()
    var division = node.get_meta("level")
    if division > 4:
            node.queue_free()
            return
    var Stamp = node.duplicate()
    Stamp.set_meta("level", division + 1)
    
    Stamp.get_node("CollisionShape2D").shape = Stamp.get_node("CollisionShape2D").shape.duplicate(true)
    var oldExtents = Stamp.get_node("CollisionShape2D").shape.extents
    Stamp.get_node("CollisionShape2D").shape.extents = Stamp.get_node("CollisionShape2D").shape.extents / 2
    
    var Clone = Stamp.duplicate()
    Clone.connect("mouse_entered", self, "subdivide", [Clone], CONNECT_ONESHOT)
    Clone.get_node("CollisionShape2D").shape = Stamp.get_node("CollisionShape2D").shape.duplicate(true)
    Clone.set_position(Clone.get_position() + Vector2(-oldExtents.x*2,-oldExtents.y*2))
    Clone.get_node("CollisionShape2D").get_node("Sprite").scale = Clone.get_node("CollisionShape2D").shape.extents * sprite_scale
    add_child(Clone)
    
    Clone = Stamp.duplicate()
    Clone.connect("mouse_entered", self, "subdivide", [Clone], CONNECT_ONESHOT)
    Clone.get_node("CollisionShape2D").shape = Stamp.get_node("CollisionShape2D").shape.duplicate(true)
    Clone.set_position(Clone.get_position() + Vector2(oldExtents.x*2,-oldExtents.y*2))
    Clone.get_node("CollisionShape2D").get_node("Sprite").scale = Clone.get_node("CollisionShape2D").shape.extents * sprite_scale
    add_child(Clone)
    
    Clone = Stamp.duplicate()
    Clone.connect("mouse_entered", self, "subdivide", [Clone], CONNECT_ONESHOT)
    Clone.get_node("CollisionShape2D").shape = Stamp.get_node("CollisionShape2D").shape.duplicate(true)
    Clone.set_position(Clone.get_position() + Vector2(-oldExtents.x*2,oldExtents.y*2))
    Clone.get_node("CollisionShape2D").get_node("Sprite").scale = Clone.get_node("CollisionShape2D").shape.extents * sprite_scale
    add_child(Clone)
    
    Stamp.connect("mouse_entered", self, "subdivide", [Stamp], CONNECT_ONESHOT)
    Stamp.set_position(Stamp.get_position() + Vector2(oldExtents.x*2,oldExtents.y*2))
    Stamp.get_node("CollisionShape2D").get_node("Sprite").scale = Stamp.get_node("CollisionShape2D").shape.extents * sprite_scale
    add_child(Stamp)

Haledire

You may want to put in a static body for the block to rest on, as everything is falling together, they have little chance to cause any meaningful collision that would separate them. so they just fall in a group.

The red blocks are just reporting where collision contacts are happening.

PopeRigby

Great. That made it work! One more thing. How can I hook this up so, say a bullet colliding with the block will cause it to be subdivided and send chunks flying off of it?

PopeRigby

I'm guessing I need to replace mouse_entered with body_entered, but that doesn't seem to be working. Something about:

E 0:00:02.949   emit_signal: Error calling method from signal 'body_entered': 'Node2D(DestructibleBlock.gd)::subdivide': Method expected 1 arguments, but called with 2..
  <C++ Source>  core/object.cpp:1228 @ emit_signal()

PopeRigby

Okay, figured everything out. Code is here for anyone who sees this is the future: https://git.haddock.cc/PopeRigby/destruction-playground

« Previous Page