Problem with a script

MagicFool64

I'm making a 2D sideview shooter, and made a script for the sprite/node who represents the player's weapon. The sprite is under the player's kinematic2D. The script should flip the sprite's h, according to mouse position, but it doesn't work. Here is the script:

extends Sprite

onready var sprite = $Weapon

func _physics_process(delta):
	if get_global_mouse_position().x < self.position.x:
		sprite.flip_h = false
	elif get_global_mouse_position().x > self.position.x:
		sprite.flip_h = true

What do I have to fix?

TwistedTwigleg

Change self.position to self.global_position and then I think it should work. You can also optimize your code a little, by using else rather than elif:

extends Sprite

onready var sprite = $Weapon

func _physics_process(delta):
	if get_global_mouse_position().x < self.global_position.x:
		sprite.flip_h = false
	else:
		sprite.flip_h = true

position gets the position of the node relative to its parent (local space), while global_position gets the position relative to origin (global space).

MagicFool64

@TwistedTwigleg said: Change self.position to self.global_position and then I think it should work. You can also optimize your code a little, by using else rather than elif:
extends Sprite

onready var sprite = $Weapon

func _physics_process(delta):
	if get_global_mouse_position().x < self.global_position.x:
		sprite.flip_h = false
	else:
		sprite.flip_h = true
position gets the position of the node relative to its parent (local space), while global_position gets the position relative to origin (global space).

Still not working. Sorry, I forgot to say it reports "Invalid set index 'flip_h' (on base: 'null instance') with value of type 'bool'."

TwistedTwigleg

Based on the error, it seems sprite is null. Do you have a child node called Weapon attached to the node that has this script?

MagicFool64

@TwistedTwigleg said: Based on the error, it seems sprite is null. Do you have a child node called Weapon attached to the node that has this script?

I attached this script at "Weapon", who is the child node of Player. Weapon is a sprite node and hasn't a child node

MagicFool64

Nevermind, I resolved

TwistedTwigleg

@MagicFool64 said: Nevermind, I resolved

Great, I am glad you figured it out!