Don't know how to use function from another node's script

gurgu22

So I have a KinematicBody2D node named Player. I want to set it so after the timer is finished (_on_timeout_complete()) it shows the pause menu. In the pause script (wich is a container) I just use show() on the pause button release (it is an android game).

Code for pause container:

extends Container

func _ready():
	hide()
	


func _on_btn_resume_pressed():
	get_tree().set_pause(false)
	hide()


func _on_btn_pause_released():
	show()
	get_tree().set_pause(true)
	find_node("Player/HUD/pause/Earth")
	$Earth/AnimationPlayer.play("up")


func _on_btn_menu_pressed():
	get_tree().set_pause(false)
	get_tree().change_scene("res://Scenes/Title Screen.tscn")


func _on_btn_restart_pressed():
	get_tree().set_pause(false)
	get_tree().reload_current_scene()

Code for Player:

extends KinematicBody2D

export(int) var speed=200
export(float) var rotation_speed=1.2

onready var pause = find_node("Player/HUD/pause")
var velocity=Vector2()
var rotation_direction=0
var timer = null
var die_delay = 1.7
var can_die = true

var motion = Vector2()
var touchleft = false
var touchright = false
var exploded = false

const is_colliding = false
const acceleration = 0.1
const UP = Vector2(0, -1)
const gravity = 0
const max_speed = 400
const max_fly_speed = 500

func _ready():
	timer = Timer.new()
	timer.set_one_shot(true)
	timer.set_wait_time(die_delay)
	timer.connect("timeout", self, "_on_timeout_complete")
	add_child(timer)
	
func _on_timeout_complete():
	get_tree().set_pause(true)


func _physics_process(delta):
	get_input()
	motion.y += gravity
	rotation+=rotation_direction*rotation_speed*delta
	move_and_slide(velocity)
	var collision = move_and_collide(velocity * delta)
	if collision && can_die:
		$Sprite.play("explode")
		can_die = false
		timer.start()
		
	
func get_input():
	rotation_direction=0
	velocity=Vector2()
	
	
	motion.y = max(motion.y-acceleration, -max_fly_speed)
	velocity=Vector2(0, -max_fly_speed).rotated(rotation)

	
	if Input.is_action_pressed("ui_right") or touchright:
		motion.x = min(motion.x+acceleration, max_speed)
		rotation_direction+=1
	elif Input.is_action_pressed("ui_left") or touchleft:
		motion.x = max(motion.x-acceleration, -max_speed)
		rotation_direction-=1
	else:
		motion.x = lerp(motion.x, 0, 0.2)
	
	if Input.is_action_pressed("ui_down"):
			get_tree().reload_current_scene()


	motion = move_and_slide(motion, UP)
	pass
	

func _on_touchright_pressed():
	touchright = true

func _on_touchleft_pressed():
	touchleft = true

func _on_touchright_released():
	touchright = false

func _on_touchleft_released():
	touchleft = false

TwistedTwigleg

If I understand what you are looking to do correctly, you just need to add the following line of code before line 33 in the code for your player:

pause.show()
# Alternatively, you could piggy-back off the _on_btn_pause_released function
# using the code below:
# pause._on_btn_pause_released()

Assuming pause is correctly grabbing the node on line 6.

gurgu22

@TwistedTwigleg Attempt to call function 'show' in base 'null instance' on a null instance.

SIsilicon28

Assuming pause is correctly grabbing the node on line 6.

@TwistedTwigleg Attempt to call function 'show' in base 'null instance' on a null instance. I guess pause wasn't correctly grabbed then. xD> @gurgu22 said:

gurgu22

@SIsilicon28 said:

Assuming pause is correctly grabbing the node on line 6.

@TwistedTwigleg Attempt to call function 'show' in base 'null instance' on a null instance. I guess pause wasn't correctly grabbed then. xD> @gurgu22 said:

Well how should it be grabbed?

TwistedTwigleg

Seems the issue is that pause is not being set correctly. What does your scene tree look like?

The onready var pause = find_node("Player/HUD/pause") code is not finding the pause node, so the variable is being set to null, which is causing the error.

Here is what I would do: use an exported NodePath so that you can set the path to the pause node from the Godot editor. I've written the modifications needed below:

Replace line 6, onready var pause = find_node("Player/HUD/pause"), with the following:

export (NodePath) var path_to_pause_node = null
var pause_node = null

Then add the following to _ready:

func _ready():
	if path_to_pause_node != null:
		pause_node = get_node(path_to_pause_node)
	else:
		print (name, " does not have pause node setup in the Godot editor!")

Finally, change _on_timeout_complete to the following:

func _on_timeout_complete():
	pause_node.show()
	# or
	# pause_node._on_btn_pause_released()

Then all you need to do is select the Player node with this script in the Godot editor, and point the node path to the node with the pause script, and then it should work.

gurgu22

@TwistedTwigleg Ok I did all that but didn't quite understand the "point the node path"

gurgu22

this is the scene tree

gurgu22

@TwistedTwigleg

SIsilicon28

Well it looks to me the Player node is the one find_node is being called from, so it shouldn't be in the path.

onready var pause = $HUD/pause # "$" is a shorthand form of "find_node".

gurgu22

@SIsilicon28 said: Well it looks to me the Player node is the one find_node is being called from, so it shouldn't be in the path.
onready var pause = $HUD/pause # "$" is a shorthand form of "find_node".

It works, thank you so much. I knew it was something easy but I am just learning the language and basically just starting programming. I don't know all these stuff.

TwistedTwigleg

@gurgu22 said: @TwistedTwigleg Ok I did all that but didn't quite understand the "point the node path"

Because it is an exported variable, you have to set/point the NodePath to a node in the Godot editor, otherwise it will resort to the default value (which is null in the code example I gave).

However, it looks like you were able to get it working thanks to @SIsilicon28 :smile: (Thanks @SIsilicon28!)

SIsilicon28

Happy to help. :)