Beginner needs help

shIxx

Hello guys, I started with Godot and I would like to try a top down 2D game. My Player is a KinematicBody2D with two AnimatedSprites. One for the feet and one for the body. with WASD I can control the feet and with the arrows left and right I can rotate the player. That works fine but I have more sprite frames e.g. melee attacks for different weapons . I found this video on YT on melle attacks https://youtube.com/watch?v=AaJopFFkmNo. He is using a Sprite and a Area2D with a Collision2D as a child.. Is this also possible with my AnimatdSprite because there is no animations editor available just the sprite pictures editor ? I have more questions so I write a list for the overview:

1) How can I make melee attacks with AnimatedSprite or have I redo everything with Sprite and Animationplayer?

2) How can I rotate tiles of a tileset? I found out that there is a possibility above the tiles were I can flip horizontal and vertical and rotate by 90 degree but I want to rotate the tiles freely, e.g. at 17 ° or 36°.

3) How can i lay out tiles without the grid? I've disabled everything on the grid, but it locks in anyway.

4) how can I make the light more realistic so that it casts a shadow?

5) Sometime (when I hit the drag margin of the camera2D) there are thin lines. Is this a bug and how can I fix this?

This is the code of my player scene:

extends KinematicBody2D

var max_speed = 200
var run_factor = 1.5
var rotation_speed = 3
var acceleration = 2000

var weapon = 1
var light = false

var direction = Vector2.ZERO
var velocity = Vector2.ZERO
var rotation_dir = 0

func get_input():
	rotation_dir = 0
# calculate the vector for the movement
	direction.x = int(Input.is_action_pressed("D")) - int(Input.is_action_pressed("A"))
	direction.y = int(Input.is_action_pressed("S")) - int(Input.is_action_pressed("W"))
	rotation_dir = int(Input.is_action_pressed("ui_right")) - int(Input.is_action_pressed("ui_left"))
	
# select a weapon
	if Input.is_action_pressed("ui_flash"):
		weapon = 1
	if Input.is_action_pressed("ui_knife"):
		weapon = 2
	if Input.is_action_pressed("ui_gun"):
		weapon = 3
	if Input.is_action_pressed("ui_shotgun"):
		weapon = 4
	if Input.is_action_pressed("ui_rifle"):
		weapon = 5
	
# only to change the sprites
	if direction.x > 0:
		$feet.play("right")
	if direction.x < 0:
		$feet.play("left")
	if direction.y != 0:
		$feet.play("walk")
		if Input.is_action_just_pressed("ui_shift"): # Doesn't work I don't know why???
			$feet.play("run")
		if weapon == 1:
			$body.play("flash_move")
		if weapon == 2:
			$body.play("knife_move")
		if weapon == 3:
			$body.play("gun_move")
		if weapon == 4:
			$body.play("shotgun_move")
		if weapon == 5:
			$body.play("rifle_move")

	if direction == Vector2.ZERO:
		$feet.play("idle")
		if weapon == 1:
			$body.play("flash_idle")
		if weapon == 2:
			$body.play("knife_idle")
		if weapon == 3:
			$body.play("gun_idle")
		if weapon == 4:
			$body.play("shotgun_idle")
		if weapon == 5:
			$body.play("rifle_idle")
	
	# flashlight
	if weapon == 1:
		if Input.is_action_just_pressed("T"):
			light = not light
		if light:
			$Light2D.show()
		else:
			$Light2D.hide()
	else:
		$Light2D.hide()
	direction = direction.normalized().rotated(rotation)
	
func _physics_process(delta):
	get_input()
	rotation += rotation_dir * rotation_speed * delta
	if direction == Vector2.ZERO:
		apply_friction(acceleration * delta)
	else:
		apply_movement(direction * acceleration * delta)
		velocity = move_and_slide(velocity)
		
	print(Input.is_action_pressed("ui_shift"))
	
func apply_friction(deceleration):
	if velocity.length() > deceleration:
		velocity -= velocity.normalized() * deceleration
	else:
		velocity = Vector2.ZERO

func apply_movement(acceleration):
	velocity += acceleration
	velocity = velocity.clamped(max_speed)

Megalomaniak

@shIxx said: I found this video on YT on melle attacks https://youtube.com/watch?v=AaJopFFkmNo. He is using a Sprite and a Area2D with a Collision2D as a child.. Is this also possible with my AnimatdSprite because there is no animations editor available just the sprite pictures editor ?

Adding an AnimationPlayer node to your actors node tree and clicking on it(highlighting it in the scene tree) gives you access to the animation editor. The AnimationPlayer should allow you to animate any property in the inspector.

TwistedTwigleg

@shlxx said: 1) How can I make melee attacks with AnimatedSprite or have I redo everything with Sprite and Animationplayer?

I have not used the AnimatedSprite node that much myself, but from what I know it should be possible to make melee attacks, as the AnimatedSprite node just changes the sprite displayed. If you have an animation for a melee attack, then it should be doable.

2) How can I rotate tiles of a tileset? I found out that there is a possibility above the tiles were I can flip horizontal and vertical and rotate by 90 degree but I want to rotate the tiles freely, e.g. at 17 ° or 36°.

To the best of my knowledge, you cannot freely rotate tiles within a Tilemap. The rotation in the tile map is limited to 90 degrees because the tiles within the Tilemap need to be the same shape for all tiles.

You'll probably need to use Sprite nodes for the tiles you want to rotate at different angles.

3) How can i lay out tiles without the grid? I've disabled everything on the grid, but it locks in anyway.

You cannot lay tiles without the grid. A TileMap has to use a grid because the tiles are stored within a two dimensional array, where each element in the array represents a tile.

You'll need to use a Sprite node if you want to have tiles at positions outside of the Tilemap grid.

4) how can I make the light more realistic so that it casts a shadow?

You'll need to use Godot's 2D shadow nodes and functionality. I personally have not used it very much myself, but I think you need Light2D and LightOccluder2D nodes.

5) Sometime (when I hit the drag margin of the camera2D) there are thin lines. Is this a bug and how can I fix this?

I dunno for sure, but enabling 2D pixel snap in the project settings should help reduce or eliminate this issue. You probably also want to turn off texture filtering for the image you are using in the tile map.

Hopefully this helps answer some of your questions! (Side note: welcome to the forums)

shIxx

Thank you for your prompt reply, 2) and 3) is clarified, .. I have to use the Sprite that's OK. 4) Thanks for the tip! That looks exactly as I imagined. 5) Disabling the filter when importing the image has helped, the thin lines are now gone. With 2D pixel snap I could not notice any change but I'll let it active meanwhile.

Now all I have to do is find out how the melee attack works and next, how can I get the player to shoot!

Adding an AnimationPlayer node to your actors node tree and clicking on it(highlighting it in the scene tree) gives you access to the animation editor. The AnimationPlayer should allow you to animate any property in the inspector. I give it a try.

Wow, I love this lightning effect: B)

shIxx

I tried the solution with the AnimationPlayer and yes, I can keyframe everything in the inspector. The problem is that it won't play the animation if I'm moving forwards, backwards or if I'm standing. Only if I move sideways. I think it's because of all the If-statements in my code. I think it's the same problem as with the run animation (line 13) . All these if queries get in the way. Is there a better solution for these queries?

Input function:

# melee attack
if Input.is_action_pressed("ui_down"):
	melee_attack()

# Change the Strites -on move
if direction.x > 0:
	$feet.play("right")
if direction.x < 0:
	$feet.play("left")
if direction.y != 0:
	speed = max_speed
	$feet.play("walk")
	if Input.is_action_just_pressed("ui_shift"): # Doesn't work and I don't know why???
		$feet.play("run")
		speed = max_speed * run_factor
	if weapon == 1:
		$body.play("flash_move")
	if weapon == 2:
		$body.play("knife_move")
......
......

Attack function:

func melee_attack():
	if weapon == 1:
		$body.play("flash_melee")
		$AnimationPlayer.play("flash_melee")
	if weapon == 2:
		$body.play("knife_melee")
		$AnimationPlayer.play("knife_melee")
	if weapon == 3:
		$body.play("gun_melee")
		$AnimationPlayer.play("gun_melee")
......
......

shIxx

I tried to upload the hole code but I'm not allowed to upload any file in this comment.

Thats why I uploadet the code to Google-Drive: https://drive.google.com/open?id=10viCCEkwHlraDV1uOiHJOBEEpqiRATqQ

TwistedTwigleg

I tried to upload the hole code but I'm not allowed to upload any file in this comment.

Strange, you should be able to upload files. Maybe the forums are not allowing GDScript files. I know that .zip files should work, so maybe zip the file and upload that?

You can probably could also use something like PasteBin, Google Drive, DropBox, OneDrive, or any other file hosting service and then post the link to the file here. Any of those services should work, even if uploading directly does not.

Edit: Never mind, I see you have uploaded the code to Google Drive. I guess we were both writing at the same time :smile:

shIxx

@TwistedTwigleg said: Strange, you should be able to upload files. Maybe the forums are not allowing GDScript files. I have tried as .txt but it didn't worked,.. I don't know why @TwistedTwigleg said: Edit: Never mind, I see you have uploaded the code to Google Drive. I guess we were both writing at the same time :smile: I wanted to write that you can delete the last post also but then I came up with the idea to upload the code on Google drive and I than have edited the post. Certainly at the same time as you answered :) Next time I will write "EDIT:" so that there are no misunderstandings

TwistedTwigleg

Hmm, I will have to later look into why .gd and .txt files are not working. As for editing the post, no worries! It's all good :smile:

shIxx

push

TwistedTwigleg

@shlxx said: push

Please try to avoid posting just to bump a topic if possible.

What have you tried since you last posted? Is the issue with the animations still present? If you can, giving an update on the situation, the issue(s) still present, and the solutions tried can help with finding potential solutions.

Looking at the code, the issue is likely other animations, like the idle animation, overriding the attack animation before it has a chance to fully play. The collision shape(s) for the attack are stilling being enabled and disabled, which means at the very least that some part of the attack animation is playing. It seems the only part of the attack animation that is not playing is the visuals.

You'll probably need to write the code so that when the attack animation is playing, no other animation can play. There are several ways to do this, but the easiest is to "lock" the animation until it is done playing.

Something like this should work (untested):

var body_animation_locked = false
func _ready():
	# Connect the animation finished signal...
	$body.connect("animation_finished", self, "_on_body_animation_finished")
func _play_animation(animation_name, lock_animation=false):
	if (body_animation_locked == false):
		$body.play(animation_name)
		body_animation_locked = lock_animation
func _on_body_animation_finished(animation_name):
	body_animation_locked = false

Then you could just replace stuff like $body.play("knife_melee") with _play_animation("knife_melee", true), which should allow the entire knife animation to play before changing to another animation.

There are other ways to do it as well, like using a state machine, but that is probably the easiest way to go about it. Hopefully this helps.

Megalomaniak

If you want to blend animations then the animationtree might be worth looking into.

shIxx

@TwistedTwigleg said: Looking at the code, the issue is likely other animations, like the idle animation, overriding the attack animation before it has a chance to fully play. Exact that was the problem. I had to add if ..... and not Input.is_action_pressed("attack"): in some places to exclude other animations so they don't overwrite the attack animation immediately.

@Megalomaniak said: If you want to blend animations then the animationtree might be worth looking into. I have a lot of if statements now and it would be better to work with the animation tree. As a beginner I did not know there is something like that. I found this Video on YT about the animation tree but that means I have to change 3/4 of my code. :/

Anyway, thank you for your help!

Megalomaniak

Well, that's all par for the course while learning. The good thing is you will remember what you've learned better for it.